Skip to content

Remove wrong tags #29868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 21, 2020
Merged

Remove wrong tags #29868

merged 10 commits into from
Oct 21, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Sep 2, 2020 •
edited by m2-assistant bot
Loading

This PR removes wrong tags

Structure of documentation space
@author ,@category, @package, and @subpackage MUST NOT be used. Documentation is organized with the use of namespaces.

Regarding https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space

Resolved issues:

  1. resolves [Issue] Remove wrong tags #30061: Remove wrong tags

@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: AdvancedSearch Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 2, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 2, 2020

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Sep 2, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Progress: pending review Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Progress: review labels Sep 2, 2020
ihor-sviziev
ihor-sviziev requested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Usik2203
Could you find all such places and remove them all at once in a single PR? I see 100 pages on github by looking for author and only few of them not related to this tag: https://github.com/magento/magento2/search?q=author&unscoped_q=author

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 2, 2020 •
edited
Loading

@Usik2203 I believe #29866 and #29867 could be merged to this PR?

@Usik2203 Usik2203 changed the title Remove wrong tags in AdvancedSearch module Remove wrong tags Sep 2, 2020
This was referenced Sep 2, 2020
Closed
Closed
@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 2, 2020

@magento run all tests

@Usik2203
Copy link
Contributor Author

Usik2203 commented Sep 2, 2020

@Usik2203
Could you find all such places and remove them all at once in a single PR? I see 100 pages on github by looking for author and only few of them not related to this tag: https://github.com/magento/magento2/search?q=author&unscoped_q=author

Hi @ihor-sviziev

Yes, I can find all places where wrong tags are. But I am not sure that we should deliver these changes in one PR.

Because on the way we will face others Static issues like we have now .
In this situation we will get Static issues for hundred files and it will require big efforts.

I think we should deliver these changes step by step by creating individual PRs.

What do you think?

Thanks

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8142 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Sep 8, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 15, 2020
Closed
@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8142 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@Usik2203 will you be able to write some static test for this rule in order to prevent re-appearing this issue again, maybe as separate PR?

@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@gabrieldagama
Copy link
Contributor

@magento run all tests

2 similar comments
@gabrieldagama
Copy link
Contributor

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Oct 21, 2020
@gabrieldagama
ENGCOM-8142: Remove wrong tags #29868
6ae4ea8
@magento-engcom-team magento-engcom-team merged commit 96a0148 into magento:2.4-develop Oct 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: AdminNotification Component: AdvancedSearch Component: CatalogInventory Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Remove wrong tags
6 participants
@Usik2203 @ihor-sviziev @magento-engcom-team @engcom-Delta @gabrieldagama @sidolov