-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixing the flaky MFTF and Integration tests that fail because of the wrong formatted date value #31509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the flaky MFTF and Integration tests that fail because of the wrong formatted date value #31509
Conversation
Hi @eduard13. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento create issue |
@magento run all tests |
@magento run Functional Tests EE, Functional Tests CE |
@magento run Functional Tests EE |
@coderimus the failed test doesn't seem to be somehow related with these changes. |
Hi @coderimus, thank you for the review.
|
@eduard13 thank you for the work you have done. Yes, the test failed related to the PageBuilder video URL waiting and doesn't have any connections to your changes. Approve from my side 👍 |
Manual QA not applicable. Moving this PR to Extended testing column |
Hi @eduard13, thank you for your contribution! |
Description (*)
This PR is supposed to fix the following failing flaky tests:
CreateProductAttributeEntityDateTest
\Magento\Catalog\Block\Product\View\Options\Type\DateTest
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Actually, the MFTF root issue is somewhere deeper, because the date input removes the 0 for days like
04/4/2021
after saving the product attribute.Contribution checklist (*)
Resolved issues: