Skip to content

Fixing the flaky MFTF and Integration tests that fail because of the wrong formatted date value #31509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jan 4, 2021

Description (*)

This PR is supposed to fix the following failing flaky tests:

  • MFTF - CreateProductAttributeEntityDateTest
  • Integration - \Magento\Catalog\Block\Product\View\Options\Type\DateTest

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Actually, the MFTF root issue is somewhere deeper, because the date input removes the 0 for days like 04/4/2021 after saving the product attribute.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fixing the flaky test that fails because of the wrong formatted date value #31518: Fixing the flaky test that fails because of the wrong formatted date value

@m2-assistant
Copy link

m2-assistant bot commented Jan 4, 2021

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 4, 2021
@eduard13
Copy link
Contributor Author

eduard13 commented Jan 4, 2021

@magento run all tests

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 4, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 4, 2021

@magento create issue

@eduard13
Copy link
Contributor Author

eduard13 commented Jan 4, 2021

@magento run all tests

@eduard13 eduard13 changed the title Fixing the flaky test that fails because of the wrong formatted date value Fixing the flaky MFTF and Integration tests that fail because of the wrong formatted date value Jan 4, 2021
@coderimus coderimus self-assigned this Jan 4, 2021
@coderimus coderimus self-requested a review January 4, 2021 19:53
@eduard13
Copy link
Contributor Author

eduard13 commented Jan 5, 2021

@magento run Functional Tests EE, Functional Tests CE

@coderimus
Copy link
Contributor

@magento run Functional Tests EE

@eduard13
Copy link
Contributor Author

eduard13 commented Jan 5, 2021

@coderimus the failed test doesn't seem to be somehow related with these changes.
Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @coderimus, thank you for the review.
ENGCOM-8596 has been created to process this Pull Request
✳️ @coderimus, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@coderimus
Copy link
Contributor

@eduard13 thank you for the work you have done. Yes, the test failed related to the PageBuilder video URL waiting and doesn't have any connections to your changes. Approve from my side 👍

@engcom-Bravo engcom-Bravo self-assigned this Jan 5, 2021
@engcom-Bravo
Copy link
Contributor

Manual QA not applicable. Moving this PR to Extended testing column

@gabrieldagama
Copy link
Contributor

Hi @eduard13, thanks for working on the failed tests, the fixes for them were merged internally and it should be fine now.
The fixes are part of this commit 427f9bf

Thanks again for the quick action.

@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2021

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: category of expertise Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fixing the flaky test that fails because of the wrong formatted date value
7 participants