Skip to content

update dealerdirect/phpcodesniffer-composer-installer dependency from ^0.5.0 to ^0.7.0 #31909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sergeynezbritskiy
Copy link
Contributor

update dealerdirect/phpcodesniffer-composer-installer package from ^0.5.0 to ^0.7.0

Description (*)

update dealerdirect/phpcodesniffer-composer-installer dependency from ^0.5.0 to ^0.7.0

Fixed Issues

  1. Fixes Update dealerdirect/phpcodesniffer-composer-installer dependency to PHP 8 compatible version #31175

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 30, 2021

Hi @sergeynezbritskiy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sergeynezbritskiy
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sergeynezbritskiy !
Thank you for the upgrade 👍

@coderimus
Copy link
Contributor

@magento run Unit Tests

@coderimus
Copy link
Contributor

Just a note: no BIC changes in the range of releases from 0.5.0 till 0.7.0. Checked original repository and release notes.

@coderimus
Copy link
Contributor

@sivaschenko this PR is ready to be reviewed and test: I checked changes and looks like there is no BIC or deleted functionality in the 3rd party module.

@hostep
Copy link
Contributor

hostep commented Feb 1, 2021

@sivaschenko, @coderimus : be aware that this dependency's constraint is already updated in Magento 2.4.2 to ^0.7.0 in order to provide support for composer v2

Don't ask me why this hasn't been merged yet in 2.4-develop but maybe we should wait on that to have happened before proceeding with this PR?

Also maybe you should (if possible) communicate a bit better with core devs, since they already did the BiC checking before.

@sivaschenko
Copy link
Member

Thanks for information @hostep ! We still need to deliver this change to php8-develop branch as there may be delays with merging 2.4.2 to 2.4-develop

@coderimus
Copy link
Contributor

Hello @sergeynezbritskiy
Thank you for the provided upgrade and all work you have done in the scope of this issue. But we have to close it because of the fact that this version was already merged to the mainline. Thank you @hostep for pointing this out.

@coderimus coderimus closed this Feb 15, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2021

Hi @sergeynezbritskiy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants