Skip to content

[ReadMe] updated readMe file for Magento_Msrp-Magento_MysqlMq modules #31938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ProkopovVitaliy
Copy link
Contributor

@ProkopovVitaliy ProkopovVitaliy commented Feb 2, 2021

Description (*)

Update README.md file for modules:

  • Magento_Msrp
  • Magento_MsrpConfigurableProduct
  • Magento_MsrpGroupedProduct
  • Magento_Multishipping
  • Magento_MysqlMq

Related Pull Requests

Fixed Issues (if relevant)

magento/devdocs# 4451: README content for modules - work in M2 Code

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] [ReadMe] updated readMe file for Magento_Msrp-Magento_MysqlMq modules #32577: [ReadMe] updated readMe file for Magento_Msrp-Magento_MysqlMq modules

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2021

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@gabrieldagama
Copy link
Contributor

Hi @ProkopovVitaliy, thanks for contributing! Can you add a reference to the issue on DevDocs as done by other PRs with the same purpose?

Thanks!

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 2, 2021
@ProkopovVitaliy ProkopovVitaliy marked this pull request as ready for review February 3, 2021 08:03
@ProkopovVitaliy ProkopovVitaliy changed the title Documentation part 1 [ReadMe] updated readMe file for Magento_Msrp-Magento_MysqlMq modules Feb 3, 2021
@ProkopovVitaliy
Copy link
Contributor Author

Hi @ProkopovVitaliy, thanks for contributing! Can you add a reference to the issue on DevDocs as done by other PRs with the same purpose?

Thanks!

Done )

@VladimirZaets
Copy link
Contributor

@magento run Performance Acceptance Tests

@bgorski
Copy link
Contributor

bgorski commented Mar 21, 2021

@ProkopovVitaliy, thank you for your contribution! I requested a few changes - most importantly events dispatched by the multishipping module. It's important to describe how modules work (like which events they listen to), but it's also very important to mention all the hooks they provide to developers. But overall the PR looks good!

@bgorski bgorski added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests improvement labels Mar 21, 2021
@ProkopovVitaliy
Copy link
Contributor Author

@bgorski Thank you for your comment.

I implemented your recommendations.

Copy link
Contributor

@bgorski bgorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ProkopovVitaliy thank you! Approving the PR.

@magento-engcom-team
Copy link
Contributor

Hi @bgorski, thank you for the review.
ENGCOM-8959 has been created to process this Pull Request

@engcom-Oscar
Copy link

@magento create issue

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@bgorski
Copy link
Contributor

bgorski commented Mar 23, 2021

@magento run Functional Tests B2B, Functional Tests EE, Unit Tests, WebAPI Tests

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2021

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Msrp Component: MsrpConfigurableProduct Component: MsrpGroupedProduct Component: Multishipping Component: MysqlMq improvement Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [ReadMe] updated readMe file for Magento_Msrp-Magento_MysqlMq modules
7 participants