Skip to content

Removed CliCacheFlushActionGroup usage for Wishlist module #31961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Removed CliCacheFlushActionGroup usage for Wishlist module #31961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
020bc36
Removed CliCacheFlushActionGroup usage (or changed value) for Wishlis…
sergiy-v Feb 3, 2021
9437843
Merge branch '2.4-develop' into mftf-CliCacheFlushActionGroup-usage-w…
sergiy-v Feb 9, 2021
b629ddb
changed values for CliCacheFlushActionGroup
sergiy-v Feb 9, 2021
f1fdf84
Merge branch '2.4-develop' into mftf-CliCacheFlushActionGroup-usage-w…
sergiy-v Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/code/Magento/Swatches/Test/Mftf/Test/AdminDisablingSwatchTooltipsTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@

<!-- Enable swatch tooltips -->
<magentoCLI command="config:set catalog/frontend/show_swatch_tooltip 1" stepKey="disableTooltips"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterEnabling">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterEnabling"/>
</after>

<!-- Go to the edit page for the "color" attribute -->
Expand Down Expand Up @@ -150,7 +148,7 @@
<!-- Disable swatch tooltips -->
<magentoCLI command="config:set catalog/frontend/show_swatch_tooltip 0" stepKey="disableTooltips"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterDisabling">
<argument name="tags" value=""/>
<argument name="tags" value="config full_page"/>
</actionGroup>

<!-- Verify swatch tooltips are not visible -->
Expand Down
4 changes: 1 addition & 3 deletions app/code/Magento/Swatches/Test/Mftf/Test/StorefrontImageColorWhenFilterByColorFilterTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProductForm"/>

<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>

<!--Select any option in the Layered navigation and verify product image-->
<amOnPage url="{{StorefrontCategoryPage.url($$createCategory.name$$)}}" stepKey="navigateToCategoryPage"/>
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Translation/Test/Mftf/Test/StorefrontInlineTranslationOnCheckoutTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@

<!-- 2. Refresh magento cache -->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterTranslateEnabled">
<argument name="tags" value=""/>
<argument name="tags" value="translate full_page"/>
</actionGroup>

<!-- 3. Go to storefront and click on cart button on the top -->
Expand Down Expand Up @@ -479,7 +479,7 @@
<magentoCLI command="config:set {{DisableTranslateInlineForStorefront.path}} {{DisableTranslateInlineForStorefront.value}}" stepKey="disableTranslateInlineForStorefront"/>
<!-- 8. Clear magento cache -->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterTranslateDisabled">
<argument name="tags" value=""/>
<argument name="tags" value="translate full_page"/>
</actionGroup>

<magentoCLI command="setup:static-content:deploy -f" stepKey="deployStaticContent"/>
Expand Down
15 changes: 3 additions & 12 deletions ...oductImportTest/AdminUrlRewriteMultipleStoreviewsProductImportWithConfigTurnedOffTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites to Yes (default)-->
<comment userInput="Enable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentEnableUrlRewriteConfig"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="enableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterEnableConfig">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterEnableConfig"/>
<createData entity="ApiCategory" stepKey="createCategory">
<field key="name">category-admin</field>
</createData>
Expand All @@ -40,10 +37,7 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites to No-->
<comment userInput="Disable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentDisableUrlRewriteConfig"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 0" stepKey="disableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterDisableConfig">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterDisableConfig"/>
</before>
<after>
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
Expand All @@ -61,10 +55,7 @@
<actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearFiltersIfSet"/>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="resetConfigurationSetting"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</after>
<actionGroup ref="SwitchCategoryStoreViewActionGroup" stepKey="switchToStoreViewEn">
<argument name="Store" value="customStoreENNotUnique.name"/>
Expand Down
14 changes: 3 additions & 11 deletions ...UrlRewrite/Test/Mftf/Test/AdminGenerateUrlRewritesForProductInCategoriesSwitchOffTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites-->
<comment userInput="Enable config to generate category/product URL Rewrites" stepKey="commentEnableConfig" />
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="enableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>

<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
<createData entity="SimpleSubCategory" stepKey="createCategory"/>
Expand All @@ -39,10 +36,7 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites-->
<comment userInput="Enable config to generate category/product URL Rewrites" stepKey="commentEnableConfig" />
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="enableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>

<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
</after>
Expand All @@ -62,9 +56,7 @@
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 0" stepKey="disableGenerateUrlRewrite"/>

<!-- 3. Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>

<!-- 4. Open Marketing - SEO & Search - URL Rewrites -->
<actionGroup ref="AdminSearchUrlRewriteByRequestPathActionGroup" stepKey="searchingUrlRewriteAfterDisablingTheConfig">
Expand Down
15 changes: 3 additions & 12 deletions ...esTest/AdminUrlRewritesForProductInAnchorCategoriesTestWithConfigurationTurnedOffTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites to Yes (default)-->
<comment userInput="Enable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentEnableUrlRewriteConfig"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="enableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterEnableConfig">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterEnableConfig"/>

<createData entity="SimpleSubCategory" stepKey="simpleSubCategory1"/>
<createData entity="SubCategoryWithParent" stepKey="simpleSubCategory2">
Expand All @@ -43,20 +40,14 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites to No-->
<comment userInput="Disable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentDisableUrlRewriteConfig"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 0" stepKey="disableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</before>
<after>
<deleteData createDataKey="createSimpleProduct" stepKey="deleteSimpleProduct"/>
<deleteData createDataKey="simpleSubCategory1" stepKey="deletesimpleSubCategory1"/>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="resetConfigurationSetting"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterDisableConfig">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterDisableConfig"/>
</after>
<!-- Steps -->
<!-- 1. Log in to Admin -->
Expand Down
15 changes: 3 additions & 12 deletions ...oductInAnchorCategoriesTest/AdminUrlRewritesForProductsWithConfigurationTurnedOffTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites to Yes (default)-->
<comment userInput="Enable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentEnableUrlRewriteConfig"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="enableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterEnableConfig">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterEnableConfig"/>
<createData entity="SimpleSubCategory" stepKey="simpleSubCategory1"/>
<!-- Create Simple product 1 and assign it to Category 1 -->
<createData entity="ApiSimpleProduct" stepKey="createSimpleProduct">
Expand All @@ -33,19 +30,13 @@
<!-- Set the configuration for Generate "category/product" URL Rewrites to No-->
<comment userInput="Disable SEO configuration setting to generate category/product URL Rewrites" stepKey="commentDisableUrlRewriteConfig"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 0" stepKey="disableGenerateUrlRewrite"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheAfterDisableConfig">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCacheAfterDisableConfig"/>
</before>
<after>
<deleteData createDataKey="createSimpleProduct" stepKey="deleteSimpleProduct"/>
<deleteData createDataKey="simpleSubCategory1" stepKey="deletesimpleSubCategory1"/>
<magentoCLI command="config:set catalog/seo/generate_category_product_rewrites 1" stepKey="resetConfigurationSetting"/>
<!--Flush cache-->
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</after>

<!-- 1. Log in to Admin -->
Expand Down
8 changes: 2 additions & 6 deletions app/code/Magento/Vault/Test/Mftf/Test/StorefrontVerifySecureURLRedirectVaultTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,11 @@
<executeJS function="return window.location.host" stepKey="hostname"/>
<magentoCLI command="config:set web/secure/base_url https://{$hostname}/" stepKey="setSecureBaseURL"/>
<magentoCLI command="config:set web/secure/use_in_frontend 1" stepKey="useSecureURLsOnStorefront"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</before>
<after>
<magentoCLI command="config:set web/secure/use_in_frontend 0" stepKey="dontUseSecureURLsOnStorefront"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
<deleteData createDataKey="customer" stepKey="deleteCustomer"/>
</after>
<executeJS function="return window.location.host" stepKey="hostname"/>
Expand Down
8 changes: 2 additions & 6 deletions app/code/Magento/Weee/Test/Mftf/Test/AdminFixedTaxValSavedForSpecificWebsiteTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@
<comment userInput="Set catalog price scope to Global" stepKey="commentSetPriceScope"/>
<magentoCLI command="config:set catalog/price/scope 0" stepKey="setPriceScopeGlobal"/>
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</before>
<after>
<!--Set catalog price scope to Global-->
Expand Down Expand Up @@ -100,9 +98,7 @@
<comment userInput="Set catalog price scope to Website" stepKey="commentSetPriceScope"/>
<magentoCLI command="config:set catalog/price/scope 1" stepKey="setPriceScopeWebsite"/>
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
<!--See available websites only 'All Websites'-->
<comment userInput="See available websites 'All Websites', 'Main Website' and Second website" stepKey="commentCheckWebsitesInProductPage"/>
<actionGroup ref="AdminProductPageOpenByIdActionGroup" stepKey="goToProductPageSecondTime">
Expand Down
8 changes: 2 additions & 6 deletions ...gento/Wishlist/Test/Mftf/Test/StorefrontAddProductsToCartFromWishlistUsingSidebarTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,15 @@
</createData>
<createData entity="Simple_US_Customer" stepKey="customer"/>
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</before>
<after>
<deleteData createDataKey="simpleProduct1" stepKey="deleteSimpleProduct1"/>
<deleteData createDataKey="simpleProduct2" stepKey="deleteSimpleProduct2"/>
<deleteData createDataKey="categoryFirst" stepKey="deleteCategoryFirst"/>
<deleteData createDataKey="categorySecond" stepKey="deleteCategorySecond"/>
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
<deleteData createDataKey="customer" stepKey="deleteCustomer"/>
</after>
<!-- Sign in as customer -->
Expand Down
8 changes: 2 additions & 6 deletions ...gento/Wishlist/Test/Mftf/Test/StorefrontCheckOptionsConfigurableProductInWishlistTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
</createData>
<createData entity="Simple_US_Customer" stepKey="customer"/>
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
</before>
<after>
Expand All @@ -46,9 +44,7 @@
</actionGroup>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
<comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
<argument name="tags" value=""/>
</actionGroup>
<comment userInput="Adding the comment to replace CliCacheFlushActionGroup action group ('cache:flush' command) for preserving Backward Compatibility" stepKey="flushCache"/>
</after>
<actionGroup ref="AdminProductPageOpenByIdActionGroup" stepKey="navigateToFirstConfigProductPage">
<argument name="productId" value="$$createFirstConfigProduct.id$$"/>
Expand Down
Loading