-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix accessibility errors on cart and checkout pages #33851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessibility errors on cart and checkout pages #33851
Conversation
Hi @vovayatsyuk. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Additionally this fixes duplicate ids ARIA errors
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @ihor-sviziev, thank you for the review.
|
Hi @Den4ik, thank you for the review.
|
@magento give me test instance |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Alfa, here is your Magento Instance: https://e46915b5399fbfc31ecc6b6711e7dcca.instances.magento-community.engineering |
@magento create issue |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Shopping cart checkout pages were giving an "ARIA IDs are not unique" error with ~90% accessibility result and Checkout payment page were with navigation and ARIA errors. After: ✔️ Shopping cart checkout pages are with 100% accessibility result without errors and Checkout payment page also with 98% without navigation and ARIA errors. Since this fix relevant to accessibility result fix and has no impact on functional regression, there is no additional testing is required on this! |
Description (*)
This PR fixes Accessibility errors reported by Lighthouse module (Available in Chrome dev tools) on the shopping cart and checkout pages.
Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: