Guard Magento_Catalog JavaScript from lack of minicart

[fredden]

Description

When the mini-cart is removed, or during the checkout, Magento_Catalog::js/product/storage/ids-storage-compare.js throws an error. The error is masked during checkout because there is a DOM element with id="checkout" which some browsers make available on window.checkout (so there's no error but the information assumed to be present isn't there).

This pull request changes the guard logic to protect against this error.

Edit: I found three more places where the lack of minicart causes errors. The minicart.js itself also suffers from this assumption, but I chose to not patch that here.

Related Pull Requests

None

Manual testing scenarios (*)

1. Remove the mini cart via layout (<referenceBlock name="minicart" remove="true" />)
2. Add an item to the 'compare' list
3. Witness error on JavaScript console / lack of error after this change

Questions or comments

None

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Guard Magento_Catalog JavaScript from lack of minicart #34513: Guard Magento_Catalog JavaScript from lack of minicart

[m2-assistant]

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-9310 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Alfa, here is your Magento Instance: https://451942eeced9f7268dbe562f2b953d3a-2-4-develop.instances.magento-community.engineering
Admin access: https://451942eeced9f7268dbe562f2b953d3a-2-4-develop.instances.magento-community.engineering/admin_e014
Login: b6701c30
Password: 10ce210c0d7c

[engcom-Alfa]

@magento create issue

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Have Magento 2.4-develop installed with sample data

Manual testing scenario:

1. Open the file app/design/frontend/Magento/luma/Magento_Theme/layout/default.xml and add this line <referenceBlock name="minicart" remove="true" />

2. Frontend: Add ay product to the cart and open Shopping cart page.

3. Inspect the page and check the error in Console

4. Open any other product and add to compare

5. Inspect the page and check the error in Console

Before: ✖️ Used to get the Uncaught TypeError

After: ✔️ There is no Uncaught TypeError

Since it is relevant to the console error fix, and has no impact on any other feature functionally, there is no additional regression is required