-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix expired admin session #34520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expired admin session #34520
Conversation
Hi @johnulecan. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me 2.4-develop instance |
Hi @johnulecan. Thank you for your request. I'm working on Magento instance for you. |
Hi @johnulecan, here is your Magento Instance: https://09f10ccb7d3677cb02d68e71cf182c6f-2-4-develop.instances.magento-community.engineering |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run WebAPI Tests, Static Tests, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run WebAPI Tests, Unit Tests, Static Tests, Semantic Version Checker, Integration Tests, Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @johnulecan, |
Description (*)
Updated At
is null if the session does not exists. Ex: Expired from Redis, removed from diskRelated Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
main.CRITICAL: TypeError: strtotime() expects parameter 1 to be string, null given in ..vendor/magento/module-security/Model/AdminSessionInfo.php:136
Questions or comments
Contribution checklist (*)