Skip to content

2.3.7 release - https://github.com/magento/magento2/pull/34514 #34606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

2.3.7 release - https://github.com/magento/magento2/pull/34514 #34606

wants to merge 8 commits into from

Conversation

kanhaiya5590
Copy link
Contributor

@kanhaiya5590 kanhaiya5590 commented Nov 11, 2021 •
edited
Loading

#34514

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2 M 2.4.3-p1 - TypeError in AdminSessionsManager.php:338 (strtotime() expects parameter 1 to be string, int given) #34415
  2. Issue existing in Magento 2.3.7-p2

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2021

Hi @kanhaiya5590. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3.7-release instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kanhaiya5590
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kanhaiya5590 kanhaiya5590 mentioned this pull request Nov 11, 2021
Merged
5 tasks
@andrewbess andrewbess self-assigned this Nov 11, 2021
@sidolov
Copy link
Contributor

sidolov commented Nov 11, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kanhaiya5590
Update AdminSessionsManager.php
be265ff 
307 | ERROR | [x] Missing short description
 308 | ERROR | [x] There must be exactly one blank line before tags
 318 | ERROR | [x] Short description should not be in multi lines
@kanhaiya5590
Update AdminSessionsManager.php
92f879d 
PHP Code Mess has found error(s):
/var/www/html/app/code/Magento/Security/Model/AdminSessionsManager.php:18	The class Magento\Security\Model\AdminSessionsManager uses sessions or cookies while not being a part of HTML Presentation layer

Failed asserting that 2 matches expected 0.
@kanhaiya5590
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kanhaiya5590
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor

Den4ik commented Nov 12, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik self-assigned this Nov 12, 2021
@Den4ik Den4ik self-requested a review November 12, 2021 14:01
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov
Copy link
Contributor

sidolov commented Dec 1, 2021

@magento run Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov
Copy link
Contributor

sidolov commented Dec 2, 2021

@magento run Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kanhaiya5590
Copy link
Contributor Author

Hi Team,

Can any one please help to fix Functional Tests EE

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Feb 28, 2022
@ishakhsuvarov
Copy link
Contributor

Hi @kanhaiya5590

Unfortunately we are unable to accept Pull requests to any branches or releases other than current 2.4-develop therefore I have to close this PR now.

Please feel free to reopen same PR into current branch if you think that issue persists.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Awaiting requested review from Den4ik

Assignees

@Den4ik Den4ik

@andrewbess andrewbess

Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kanhaiya5590 @sidolov @Den4ik @ihor-sviziev @ishakhsuvarov @andrewbess