Skip to content

Fixed Issue #35900: Allow "Show all products" in category page #35987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Bashev
Copy link
Contributor

@Bashev Bashev commented Aug 19, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Catalog Page Empty if "Allow All Products Per Page" is set to "Yes" #35900

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2022

Hi @Bashev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P0 This generally occurs in cases when the entire functionality is blocked. Progress: pending review labels Aug 19, 2022
@Bashev Bashev changed the title Issue 35900 Allow "Show all products" in category page (Issue 35900) Aug 19, 2022
@Bashev
Copy link
Contributor Author

Bashev commented Aug 19, 2022

@magento give me test instance

@magento-deployment-service
Copy link

Hi @Bashev. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@Bashev
Copy link
Contributor Author

Bashev commented Aug 19, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Bashev Bashev changed the title Allow "Show all products" in category page (Issue 35900) Fixed Issue #35900: Allow "Show all products" in category page Aug 19, 2022
@Bashev
Copy link
Contributor Author

Bashev commented Aug 20, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Bashev
Copy link
Contributor Author

Bashev commented Aug 20, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Bashev
Copy link
Contributor Author

Bashev commented Aug 22, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Bashev
Copy link
Contributor Author

Bashev commented Aug 23, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Bashev
Copy link
Contributor Author

Bashev commented Aug 30, 2022

Resolved internally.

@JoergLindner
Copy link

Sorry, this is not a complete fix, as it shows now all products even if they are marked as 'search', which suppose to be shown only while searching it, not by just looking into a category. Here it should only shown products with 'catalog,search' or 'catalog' setting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P0 This generally occurs in cases when the entire functionality is blocked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog Page Empty if "Allow All Products Per Page" is set to "Yes"
2 participants