Skip to content

Remove forbidden @author tag #37009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

Remove forbidden @author tag #37009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
612dda7
Remove forbidden @author tag
fredden Mar 7, 2023
30ea35d
Merge branch '2.4-develop' into no-author/reports
engcom-Echo Dec 18, 2023
f9bf942
Merge branch '2.4-develop' into no-author/reports
engcom-Echo Jun 19, 2024
865f770
Fixed static test failures
engcom-Echo Jun 20, 2024
890a386
Merge remote-tracking branch 'upstream/2.4-develop' into no-author/re…
fredden Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* Adminhtml refunded report page content block
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Refunded extends \Magento\Backend\Block\Widget\Grid\Container
Expand All @@ -22,7 +21,7 @@ class Refunded extends \Magento\Backend\Block\Widget\Grid\Container
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
* @inheritdoc
*/
protected function _construct()
{
Expand Down
1 change: 0 additions & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
/**
* Adminhtml refunded report grid block
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.DepthOfInheritance)
*/
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid
Expand Down
3 changes: 1 addition & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Sales/Sales.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* Adminhtml sales report page content block
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Sales extends \Magento\Backend\Block\Widget\Grid\Container
Expand All @@ -22,7 +21,7 @@ class Sales extends \Magento\Backend\Block\Widget\Grid\Container
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
* @inheritdoc
*/
protected function _construct()
{
Expand Down
3 changes: 1 addition & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* Adminhtml shipping report page content block
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Shipping extends \Magento\Backend\Block\Widget\Grid\Container
Expand All @@ -22,7 +21,7 @@ class Shipping extends \Magento\Backend\Block\Widget\Grid\Container
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
* @inheritdoc
*/
protected function _construct()
{
Expand Down
1 change: 0 additions & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
/**
* Adminhtml shipping report grid block
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.DepthOfInheritance)
*/
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid
Expand Down
3 changes: 1 addition & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Sales/Tax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* Adminhtml tax report page content block
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Tax extends \Magento\Backend\Block\Widget\Grid\Container
Expand All @@ -22,7 +21,7 @@ class Tax extends \Magento\Backend\Block\Widget\Grid\Container
protected $_template = 'Magento_Reports::report/grid/container.phtml';

/**
* {@inheritdoc}
* @inheritdoc
*/
protected function _construct()
{
Expand Down
1 change: 0 additions & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Sales/Tax/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
/**
* Adminhtml tax report grid block
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.DepthOfInheritance)
*/
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\AbstractGrid
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

/**
* Adminhtml abandoned shopping cart report page content block
*
* @author Magento Core Team <[email protected]>
*/
class Abandoned extends \Magento\Backend\Block\Widget\Grid\Container
{
/**
* Initialize
*
* @return void
*/
protected function _construct()
Expand Down
1 change: 0 additions & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
*
* @method \Magento\Reports\Model\ResourceModel\Quote\Collection getCollection()
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.DepthOfInheritance)
*/
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\Shopcart
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

/**
* Adminhtml Shopping cart customers report page content block
*
* @author Magento Core Team <[email protected]>
*/
class Customer extends \Magento\Backend\Block\Widget\Grid\Container
{
/**
* Initialize
*
* @return void
*/
protected function _construct()
Expand Down
9 changes: 8 additions & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
/**
* Adminhtml items in carts report grid block
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.DepthOfInheritance)
*/
class Grid extends \Magento\Reports\Block\Adminhtml\Grid\Shopcart
Expand All @@ -35,6 +34,8 @@ public function __construct(
}

/**
* Initialize
*
* @return void
*/
protected function _construct()
Expand All @@ -44,6 +45,8 @@ protected function _construct()
}

/**
* Prepare collection
*
* @return \Magento\Backend\Block\Widget\Grid
*/
protected function _prepareCollection()
Expand All @@ -60,6 +63,8 @@ protected function _prepareCollection()
}

/**
* After load collection
*
* @return \Magento\Backend\Block\Widget\Grid|void
*/
protected function _afterLoadCollection()
Expand All @@ -68,6 +73,8 @@ protected function _afterLoadCollection()
}

/**
* Prepare columns
*
* @return \Magento\Backend\Block\Widget\Grid\Extended
*/
protected function _prepareColumns()
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

/**
* Adminhtml Shopping cart products report page content block
*
* @author Magento Core Team <[email protected]>
*/
class Product extends \Magento\Backend\Block\Widget\Grid\Container
{
/**
* Initialize
*
* @return void
*/
protected function _construct()
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Adminhtml/Wishlist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Adminhtml wishlist report page content block
*
* @deprecated 100.3.3
* @author Magento Core Team <[email protected]>
* @see Nothing
*/
class Wishlist extends \Magento\Backend\Block\Template
{
Expand Down
10 changes: 8 additions & 2 deletions app/code/Magento/Reports/Block/Adminhtml/Wishlist/Grid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

/**
* Adminhtml wishlist report grid block
*
* @author Magento Core Team <[email protected]>
*/
class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
{
Expand All @@ -18,6 +16,8 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
protected $_productsFactory;

/**
* Initialize
*
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Backend\Helper\Data $backendHelper
* @param \Magento\Reports\Model\ResourceModel\Wishlist\Product\CollectionFactory $productsFactory
Expand All @@ -34,6 +34,8 @@ public function __construct(
}

/**
* Initialize
*
* @return void
*/
protected function _construct()
Expand All @@ -45,6 +47,8 @@ protected function _construct()
}

/**
* Prepare collection
*
* @return $this
*/
protected function _prepareCollection()
Expand All @@ -63,6 +67,8 @@ protected function _prepareCollection()
}

/**
* Prepare Columns
*
* @return \Magento\Backend\Block\Widget\Grid\Extended
*/
protected function _prepareColumns()
Expand Down
5 changes: 3 additions & 2 deletions app/code/Magento/Reports/Block/Product/AbstractProduct.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

/**
* Reports Recently Products Abstract Block
*
* @author Magento Core Team <[email protected]>
*/
abstract class AbstractProduct extends \Magento\Catalog\Block\Product\AbstractProduct
{
Expand Down Expand Up @@ -37,6 +35,8 @@ abstract class AbstractProduct extends \Magento\Catalog\Block\Product\AbstractPr
protected $_indexFactory;

/**
* Initialize
*
* @param \Magento\Catalog\Block\Product\Context $context
* @param \Magento\Catalog\Model\Product\Visibility $productVisibility
* @param \Magento\Reports\Model\Product\Index\Factory $indexFactory
Expand Down Expand Up @@ -82,6 +82,7 @@ protected function _getProductsToSkip()

/**
* Public method for retrieve Product Index model
*
* @throws \Magento\Framework\Exception\LocalizedException
* @return \Magento\Reports\Model\Product\Index\AbstractIndex
*/
Expand Down
7 changes: 3 additions & 4 deletions app/code/Magento/Reports/Block/Product/Compared.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
/**
* Reports Recently Compared Products Block
*
* @author Magento Core Team <[email protected]>
* @deprecated 100.2.0
* @see nothing
*/
class Compared extends \Magento\Reports\Block\Product\AbstractProduct
{
/**
* Config path for compared products count
*/
const XML_PATH_RECENTLY_COMPARED_COUNT = 'catalog/recently_products/compared_count';
public const XML_PATH_RECENTLY_COMPARED_COUNT = 'catalog/recently_products/compared_count';

/**
* Compared Product Index type
Expand All @@ -43,8 +43,7 @@ public function getPageSize()
}

/**
* Prepare to html
* Check has compared products
* Prepare to html Check has compared products
*
* @return string
*/
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Reports/Block/Product/Viewed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
/**
* Reports Recently Viewed Products Block
*
* @author Magento Core Team <[email protected]>
* @deprecated 100.2.0
* @see nothing
*/
class Viewed extends AbstractProduct implements IdentityInterface
{
/**
* Config path to recently viewed product count
*/
const XML_PATH_RECENTLY_VIEWED_COUNT = 'catalog/recently_products/viewed_count';
public const XML_PATH_RECENTLY_VIEWED_COUNT = 'catalog/recently_products/viewed_count';

/**
* Viewed Product Index type
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Reports/Block/Product/Widget/Viewed/Item.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* Reports Recently Viewed Products Widget
*
* @deprecated 100.3.3
* @author Magento Core Team <[email protected]>
* @see nothing
*/
class Item extends \Magento\Catalog\Block\Product\AbstractProduct implements \Magento\Widget\Block\BlockInterface
{
Expand Down
5 changes: 2 additions & 3 deletions app/code/Magento/Reports/Controller/Adminhtml/Index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@

/**
* sales admin controller
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Reports\Controller\Adminhtml;

/**
* phpcs:disable Magento2.Classes.AbstractApi
* @api
* @since 100.0.2
*/
Expand All @@ -22,7 +21,7 @@ abstract class Index extends \Magento\Backend\App\Action
*
* @see _isAllowed()
*/
const ADMIN_RESOURCE = 'Magento_Reports::report';
public const ADMIN_RESOURCE = 'Magento_Reports::report';

/**
* @var \Magento\Framework\App\Response\Http\FileFactory
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Reports/Controller/Adminhtml/Report/AbstractReport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Admin abstract reports controller
*
* @author Magento Core Team <[email protected]>
*/

namespace Magento\Reports\Controller\Adminhtml\Report;
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Reports/Controller/Adminhtml/Report/Customer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
declare(strict_types=1);

/**
*
* Customer reports admin controller
*
*/
namespace Magento\Reports\Controller\Adminhtml\Report;

Expand Down
3 changes: 1 addition & 2 deletions app/code/Magento/Reports/Controller/Adminhtml/Report/Product.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@

/**
* Product reports admin controller
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Reports\Controller\Adminhtml\Report;

/**
* phpcs:disable Magento2.Classes.AbstractApi
* @api
* @since 100.0.2
*/
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Reports/Controller/Adminhtml/Report/Review.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

/**
* Review reports admin controller
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Reports\Controller\Adminhtml\Report;

Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

/**
* Sales report admin controller
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Reports\Controller\Adminhtml\Report;

Expand Down
Loading