Skip to content

Remove forbidden @author tag #37013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/code/Magento/Sales/Block/Items/AbstractItems.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,14 @@
/**
* Abstract block for display sales (quote/order/invoice etc.) items
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.NumberOfChildren)
*/
class AbstractItems extends \Magento\Framework\View\Element\Template
{
/**
* Block alias fallback
*/
const DEFAULT_TYPE = 'default';
public const DEFAULT_TYPE = 'default';

/**
* Retrieve item renderer block
Expand Down
15 changes: 14 additions & 1 deletion app/code/Magento/Sales/Block/Order/Creditmemo.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
* Sales order view block
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Creditmemo extends \Magento\Sales\Block\Order\Creditmemo\Items
Expand Down Expand Up @@ -52,6 +51,8 @@ public function __construct(
}

/**
* Prepare Layout
*
* @return void
*/
protected function _prepareLayout()
Expand All @@ -62,6 +63,8 @@ protected function _prepareLayout()
}

/**
* Get payment info html
*
* @return string
*/
public function getPaymentInfoHtml()
Expand Down Expand Up @@ -106,6 +109,8 @@ public function getBackTitle()
}

/**
* Invoice URL getter
*
* @param object $order
* @return string
*/
Expand All @@ -115,6 +120,8 @@ public function getInvoiceUrl($order)
}

/**
* Shipment URL getter
*
* @param object $order
* @return string
*/
Expand All @@ -124,6 +131,8 @@ public function getShipmentUrl($order)
}

/**
* Get order view URL
*
* @param object $order
* @return string
*/
Expand All @@ -133,6 +142,8 @@ public function getViewUrl($order)
}

/**
* Get CreditMemo Print Url
*
* @param object $creditmemo
* @return string
*/
Expand All @@ -142,6 +153,8 @@ public function getPrintCreditmemoUrl($creditmemo)
}

/**
* Get PrintAll CreditMemos Url
*
* @param object $order
* @return string
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
* Sales Order Email creditmemo items
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Items extends \Magento\Sales\Block\Items\AbstractItems
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Sales/Block/Order/Email/Items.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Sales Order Email order items
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Sales\Block\Order\Email;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
* Sales Order Email items default renderer
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class DefaultItems extends Template
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
* Sales Order Email items default renderer
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class DefaultOrder extends \Magento\Framework\View\Element\Template
Expand Down
11 changes: 6 additions & 5 deletions app/code/Magento/Sales/Block/Order/Info.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,16 @@
*/
namespace Magento\Sales\Block\Order;

use Magento\Sales\Model\Order\Address;
use Magento\Framework\View\Element\Template\Context as TemplateContext;
use Magento\Framework\Registry;
use Magento\Framework\View\Element\Template\Context as TemplateContext;
use Magento\Payment\Helper\Data as PaymentHelper;
use Magento\Sales\Model\Order\Address;
use Magento\Sales\Model\Order\Address\Renderer as AddressRenderer;

/**
* Invoice view comments form
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Info extends \Magento\Framework\View\Element\Template
Expand All @@ -26,8 +25,6 @@ class Info extends \Magento\Framework\View\Element\Template
protected $_template = 'Magento_Sales::order/info.phtml';

/**
* Core registry
*
* @var \Magento\Framework\Registry
*/
protected $coreRegistry = null;
Expand Down Expand Up @@ -64,6 +61,8 @@ public function __construct(
}

/**
* Prepare Layout
*
* @return void
*/
protected function _prepareLayout()
Expand All @@ -74,6 +73,8 @@ protected function _prepareLayout()
}

/**
* Get payment info html
*
* @return string
*/
public function getPaymentInfoHtml()
Expand Down
4 changes: 0 additions & 4 deletions app/code/Magento/Sales/Block/Order/Invoice/Items.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Sales order view items block
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Sales\Block\Order\Invoice;

Expand All @@ -20,8 +18,6 @@
class Items extends \Magento\Sales\Block\Items\AbstractItems
{
/**
* Core registry
*
* @var \Magento\Framework\Registry
*/
protected $_coreRegistry = null;
Expand Down
3 changes: 0 additions & 3 deletions app/code/Magento/Sales/Block/Order/Items.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
* See COPYING.txt for license details.
*/

/**
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Sales\Block\Order;

use Magento\Framework\App\ObjectManager;
Expand Down
3 changes: 1 addition & 2 deletions app/code/Magento/Sales/Controller/Adminhtml/Order/Create.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
/**
* Adminhtml sales orders creation process controller
*
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.NumberOfChildren)
* @SuppressWarnings(PHPMD.AllPurposeAction)
*/
Expand Down Expand Up @@ -344,7 +343,7 @@ protected function _processActionData($action = null)
$this->messageManager->addSuccessMessage(__('The coupon code has been accepted.'));
}
}
} elseif (isset($data['coupon']['code']) && empty($couponCode)) {
} elseif (isset($data['coupon']['code']) && $couponCode=='') {
$this->messageManager->addSuccessMessage(__('The coupon code has been removed.'));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

/**
* Adminhtml sales order view gift messages controller
*
* @author Magento Core Team <[email protected]>
*/
abstract class Giftmessage extends \Magento\Backend\App\Action
{
Expand All @@ -17,7 +15,7 @@ abstract class Giftmessage extends \Magento\Backend\App\Action
*
* @see _isAllowed()
*/
const ADMIN_RESOURCE = 'Magento_Sales::sales_order';
public const ADMIN_RESOURCE = 'Magento_Sales::sales_order';

/**
* Retrieve gift message save model
Expand Down
6 changes: 1 addition & 5 deletions app/code/Magento/Sales/Controller/Adminhtml/Transactions.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

/**
* Adminhtml sales transactions controller
*
* @author Magento Core Team <[email protected]>
*/
abstract class Transactions extends \Magento\Backend\App\Action
{
Expand All @@ -23,11 +21,9 @@ abstract class Transactions extends \Magento\Backend\App\Action
*
* @see _isAllowed()
*/
const ADMIN_RESOURCE = 'Magento_Sales::transactions';
public const ADMIN_RESOURCE = 'Magento_Sales::transactions';

/**
* Core registry
*
* @var Registry
*/
protected $_coreRegistry = null;
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Sales/Helper/Data.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@

/**
* Sales module base helper
*
* @author Magento Core Team <[email protected]>
*/
class Data extends \Magento\Framework\App\Helper\AbstractHelper
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@

/**
* Product quote initializer
*
* @author Magento Core Team <[email protected]>
*
*/
namespace Magento\Sales\Model\AdminOrder\Product\Quote;

Expand All @@ -29,6 +26,8 @@ public function __construct(
}

/**
* Initializing quote product
*
* @param \Magento\Quote\Model\Quote $quote
* @param \Magento\Catalog\Model\Product $product
* @param \Magento\Framework\DataObject $config
Expand Down
4 changes: 3 additions & 1 deletion app/code/Magento/Sales/Model/Config/Ordered.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@

/**
* Configuration class for ordered items
* phpcs:disable Magento2.Classes.AbstractApi
* @api
*
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
abstract class Ordered extends \Magento\Framework\App\Config\Base
Expand Down Expand Up @@ -144,6 +144,7 @@ protected function _prepareConfigArray($code, $totalConfig)

/**
* Aggregate before/after information from all items and sort totals based on this data
*
* Invoke simple sorting if the first element contains the "sort_order" key
*
* @param array $config
Expand Down Expand Up @@ -178,6 +179,7 @@ function ($a, $b) {

/**
* Initialize collectors array.
*
* Collectors array is array of total models ordered based on configuration settings
*
* @return $this
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

/**
* Base class for credit memo total
* phpcs:disable Magento2.Classes.AbstractApi
* @api
*
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
abstract class AbstractTotal extends \Magento\Sales\Model\Order\Total\AbstractTotal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

/**
* Base class for invoice total
* phpcs:disable Magento2.Classes.AbstractApi
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
abstract class AbstractTotal extends \Magento\Sales\Model\Order\Total\AbstractTotal
Expand Down
2 changes: 0 additions & 2 deletions app/code/Magento/Sales/Model/Order/Invoice/Total/Shipping.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

/**
* Order invoice shipping total calculation model
*
* @author Magento Core Team <[email protected]>
*/
class Shipping extends AbstractTotal
{
Expand Down
6 changes: 2 additions & 4 deletions app/code/Magento/Sales/Model/Order/Payment/Transaction.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
* By default transactions are saved as closed.
*
* @api
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @since 100.0.2
Expand All @@ -26,7 +25,7 @@ class Transaction extends AbstractModel implements TransactionInterface
/**
* Raw details key in additional info
*/
const RAW_DETAILS = 'raw_details_info';
public const RAW_DETAILS = 'raw_details_info';

/**
* Order instance
Expand Down Expand Up @@ -95,8 +94,6 @@ class Transaction extends AbstractModel implements TransactionInterface
protected $_eventObject = 'order_payment_transaction';

/**
* Order website id
*
* @var int
*/
protected $_orderWebsiteId = null;
Expand Down Expand Up @@ -409,6 +406,7 @@ public function canVoidAuthorizationCompletely()
return true;
} catch (\Magento\Framework\Exception\LocalizedException $e) {
// jam all logical exceptions, fallback to false
return false;
}
return false;
}
Expand Down
Loading