-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Multi Language frontend bug fix #4705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Language frontend bug fix #4705
Conversation
Magento 2 does not translate frontend error messages. These changes fix this bug.
@antboiko @piotrekkaminski |
@LucScu It means the Magento develop branch does not pass the CI tests: https://travis-ci.org/magento/magento2 |
@doveid Why it fails if the pull request is only string modifications? |
@LucScu I recommend you to read about git branching how works the basics of git. |
@doveid I know how git works, i don't understand why string modifications do fail the CI? Or the fail is caused by other thing? |
@doveid Why CI check is now passed with same changes? |
@doveid thank you for your contribution, we have ticket MAGETWO-55058 to process this PR. Best, |
/cc #4038 Lots of duplicates here. |
Internal ticket: MAGETWO-56553 |
Hey @doveid can you check with the latest mainline if these phrases aren't being fixed/translated already, since we've merge another similar PR and made some fixes internally. |
[TSG] Fixes for 2.2 (pr115) (2.2.10-develop)
Magento 2 does not translate frontend error messages. These changes fix this bug.