Skip to content

Multi Language frontend bug fix #4705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Multi Language frontend bug fix #4705

wants to merge 2 commits into from

Conversation

DavidBelicza
Copy link

Magento 2 does not translate frontend error messages. These changes fix this bug.

Magento 2 does not translate frontend error messages. These changes fix this bug.
@LucScu
Copy link

LucScu commented May 31, 2016

@antboiko @piotrekkaminski
What does it means "The Travis CI build failed" ?

@DavidBelicza
Copy link
Author

@LucScu It means the Magento develop branch does not pass the CI tests: https://travis-ci.org/magento/magento2

@LucScu
Copy link

LucScu commented Jun 6, 2016

@doveid Why it fails if the pull request is only string modifications?

@DavidBelicza
Copy link
Author

@LucScu I recommend you to read about git branching how works the basics of git.

@LucScu
Copy link

LucScu commented Jun 6, 2016

@doveid I know how git works, i don't understand why string modifications do fail the CI? Or the fail is caused by other thing?

@LucScu
Copy link

LucScu commented Jun 10, 2016

@doveid Why CI check is now passed with same changes?

@antboiko
Copy link

antboiko commented Jul 5, 2016

@doveid thank you for your contribution, we have ticket MAGETWO-55058 to process this PR.

Best,
Anton.

@adragus-inviqa
Copy link
Contributor

/cc #4038

Lots of duplicates here.

@vkorotun vkorotun added Area: Frontend and removed CS labels Aug 3, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bugfix and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 4, 2016
@vkorotun
Copy link
Contributor

vkorotun commented Aug 8, 2016

Internal ticket: MAGETWO-56553

@vkorotun vkorotun added the linked label Aug 8, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@vkorotun
Copy link
Contributor

Hey @doveid can you check with the latest mainline if these phrases aren't being fixed/translated already, since we've merge another similar PR and made some fixes internally.
Thx.

@vkorotun vkorotun self-assigned this Sep 14, 2016
magento-cicd2 pushed a commit that referenced this pull request Oct 8, 2019
[TSG] Fixes for 2.2 (pr115) (2.2.10-develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bugfix Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants