Make "is_required" and "is_visible" properties of telephone, company and fax attributes of addresses configurable

[avstudnitz]

Fixes #1691.
We added configuration for telephone, fax and company fields in configuration:

You can set them to be optional, required, or not shown at all. All necessary forms have been adjusted.

[magento-cicd2]

All committers have signed the CLA.

[Igloczek]

Will be nice to improve code formatting in templates 😉 Copy-paste code bellow.

<div class="field company <?php echo $block->isRequired() ? 'required' : '' ?>">
    <label for="company" class="label">
        <span>
            <?php echo $block->escapeHtml(__('Company')) ?>
        </span>
    </label>
    <div class="control">
        <?php
            $_validationClass = $block->escapeHtmlAttr(
                $this->helper('Magento\Customer\Helper\Address')
                     ->getAttributeValidationClass('company')
            );
        ?>
        <input type="text"
               name="company"
               id="company"
               value="<?php echo $block->escapeHtmlAttr($block->getCompany()) ?>"
               title="<?php echo $block->escapeHtmlAttr(__('Company')) ?>"
               class="input-text <?php echo $_validationClass ?? '' ?>"
         >
    </div>
</div>

PS. Remember about new line at the end of file.

[Igloczek]

<div class="field fax <?php echo $block->isRequired() ? 'required' : '' ?>">
    <label for="fax" class="label">
        <span>
            <?php echo $block->escapeHtml(__('Fax')) ?>
        </span>
    </label>
    <div class="control">
        <?php
            $_validationClass = $block->escapeHtmlAttr(
                $this->helper('Magento\Customer\Helper\Address')
                     ->getAttributeValidationClass('fax')
            );
        ?>
        <input type="text"
               name="fax"
               id="fax"
               value="<?php echo $block->escapeHtmlAttr($block->getFax()) ?>"
               title="<?php echo $block->escapeHtmlAttr(__('Fax')) ?>"
               class="input-text <?php echo $_validationClass ?? '' ?>"
        >
    </div>
</div>

[Igloczek]

<div class="field telephone <?php echo $block->isRequired() ? 'required' : '' ?>">
    <label for="telephone" class="label">
        <span>
            <?php echo $block->escapeHtml(__('Phone Number')) ?>
        </span>
    </label>
    <div class="control">
        <?php
            $_validationClass = $block->escapeHtmlAttr(
                $this->helper('Magento\Customer\Helper\Address')
                     ->getAttributeValidationClass('fax')
            );
        ?>
        <input type="text"
               name="telephone"
               id="telephone"
               value="<?php echo $block->escapeHtmlAttr($block->getTelephone()) ?>"
               title="<?php echo $block->escapeHtmlAttr(__('Phone Number')) ?>"
               class="input-text <?php echo $_validationClass ?? '' ?>"
        >
    </div>
</div>

[hostep]

Nice work @avstudnitz!

Just something I have to think about, take a look at this code:

magento2/app/code/Magento/Checkout/Block/Checkout/LayoutProcessor.php

Lines 323 to 339 in 7c81c1d

	'company' => [
	'validation' => [
	'min_text_length' => 0,
	],
	],
	'fax' => [
	'validation' => [
	'min_text_length' => 0,
	],
	],
	'telephone' => [
	'config' => [
	'tooltip' => [
	'description' => __('For delivery questions.'),
	],
	],
	],

I think you'll need to figure something out, to add the required-entry validation of those 3 billing address fields in there, based on the chosen configuration?

(not 100% sure about this though)

[avstudnitz]

@hostep In our tests it set the correct validation on the checkout without modifying anything, based on the attribute settings. so I think this is not necessary.

[fooman]

Nice work - I believe if you want to increase your chances of a quick merge I suggest taking a look at making the constructor changes here https://github.com/magento/magento2/pull/8519/files#diff-abecee6a6fc7dfb7ec46099d0ffec980R55 use an optional parameter similar to how @dmanners has been doing here https://github.com/magento/magento2/pull/8481/files#diff-ab7a66b8a18582a01b9661fe9270486aR51

[vrann]

@avstudnitz Thank you for the contribution! I'm verifying it at the moment.
Can you please take a look at the failing Travis tests?

[vrann]

nice!

[avstudnitz]

@vrann Yes, will do that over the weekend. It's the unit tests, right?

[vrann]

@avstudnitz actually nevermind issues in the unit tests (Travis), it was fast fix and I just did it.
Verifying the functionality and will let you know is there anything need to be changed.

[vrann]

@avstudnitz from the review perspective all the changes looks good and the functionality works perfectly.

[avstudnitz]

Great to hear @vrann!

[okorshenko]

@avstudnitz thank you for your contribution. PR is merged