Fix /lib/ ignore ruleset #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See magento#81 , the expected behaviour is: ignoring the '/lib/* directory the relative path is matched without the starting directory separator. see https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Filters/Filter.php#L221 hence the removal of the starting `/`
|
@Rud5G thank you fo the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81 , the expected behaviour is: ignoring the '/lib/* directory
the relative path is matched without the starting directory separator.
see https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Filters/Filter.php#L221
hence the removal of the starting
/