Skip to content

[TASK] Allow urls without .html for CMS. (#936) - Round 2 #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tjwiebell
Copy link
Contributor

Description

Allows URLs without .html extension

Related Issue

Closes #ISSUE_NUMBER.

Verification Steps

  1. Go to the FOO page.
  2. Verify the BAR shows up.
  3. Make sure BAZ does a thing.

How Have YOU Tested this?

Screenshots / Screen Captures (if appropriate):

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@vercel
Copy link

vercel bot commented Apr 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@tjwiebell
Copy link
Contributor Author

@lewisvoncken - We had to rollback this change as it was causing issues when running yarn stage:venia. We are interested in getting this landed, so please let us know if you'd like us to pick it up to resolve that bug and get this merged.

@zetlen
Copy link
Contributor

zetlen commented Apr 5, 2019

I think this just needs to be the default case for the response conditional, because it's the most general match!

@tjwiebell
Copy link
Contributor Author

Closing for the same reason here:

#1029 (comment)

@tjwiebell tjwiebell closed this Apr 30, 2019
@tjwiebell tjwiebell deleted the feature/lewis-cms-extension-redo branch October 31, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants