-
Notifications
You must be signed in to change notification settings - Fork 685
Update queries for latest 2.3 schema and add validator script #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Because this validation is dependent on a connected Magento instance, I haven't integrated it into the test suite or CI. Right now, we don't have a connected Magento instance for either. |
16ba8d4
to
a82f27f
Compare
Generated by 🚫 dangerJS |
Pull Request Test Coverage Report for Build 1099
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as advertised. This will be a helpful addition. 👍
Just two minor changes requested.
9b0a9ad
to
a8ce14d
Compare
Works fine on my end! |
7d714ac
to
48dcb3c
Compare
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
As of magento/graphql-ce#132 the Product schema has changed; the
small_image
is now an object withurl
andpath
parameters. This PR updates the corresponding queries, prop types, and tests to handle this change.When merged, this will make Venia incompatible with Magento 2.3 prior to this commit.
For developer discoverability, this PR adds a script which validates queries against the connected Magento instance:
npm run-script validate:venia:gql
.Error example:
In a later PR, it would be a good idea to run this validator every time a query changes, or when a Magento instance is connected...