Skip to content

Super basic implementation of category page using apollo client for data fetching #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Super basic implementation of category page using apollo client for data fetching #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/peregrine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "https://github.com/magento-research/peregrine"
},
"scripts": {
"build": "babel src -d dist --ignore test.js",
"build": "babel src -d dist --ignore '*.test.js,*.spec.js'",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to build the test files for distributing. But I also caught this generating built test artifacts, so jest would run all tests twice. Random tech debt from monorepo move

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using .spec.js for most of initial development, IIRC. When did we start having .test.js files, and why? Should change them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did we start having .test.js files

October 31, 2017. We can change it in a separate PR

"danger": "danger-ci",
"clean": "rimraf dist",
"prepare": "npm-merge-driver install",
Expand Down
3 changes: 2 additions & 1 deletion packages/venia-concept/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ const plugins = [
'syntax-jsx',
'transform-class-properties',
'transform-object-rest-spread',
['transform-react-jsx', { pragma: 'createElement' }]
['transform-react-jsx', { pragma: 'createElement' }],
'graphql-tag'
];

// define default babel options
Expand Down
237 changes: 235 additions & 2 deletions packages/venia-concept/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions packages/venia-concept/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,14 @@
},
"dependencies": {
"@magento/peregrine": "^0.4.0",
"apollo-boost": "^0.1.9",
"babel-runtime": "^6.26.0",
"dotenv": "^4.0.0",
"feather-icons": "^4.6.0",
"graphql": "^0.13.2",
"graphql-tag": "^2.9.2",
"react": "^16.2.0",
"react-apollo": "^2.1.5",
"react-dom": "^16.2.0",
"react-redux": "^5.0.6",
"react-router-dom": "^4.2.2",
Expand All @@ -30,6 +34,7 @@
"@magento/pwa-buildpack": "^0.8.2",
"babel-core": "^6.26.0",
"babel-loader": "^7.1.2",
"babel-plugin-graphql-tag": "^1.6.0",
"babel-plugin-syntax-dynamic-import": "^6.18.0",
"babel-plugin-syntax-jsx": "^6.18.0",
"babel-plugin-transform-class-properties": "^6.24.1",
Expand Down
Loading