Prevent unit/integration tests from running against stale build artifacts #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewML
commented
Jun 18, 2018
| @@ -16,7 +16,7 @@ | |||
| "start:debug": "node --inspect-brk ./node_modules/.bin/webpack-dev-server --progress --color --env.phase development" | |||
| }, | |||
| "dependencies": { | |||
| "@magento/peregrine": "^0.3.0", | |||
| "@magento/peregrine": "^0.4.0", | |||
There was a problem hiding this comment.
This fixes a bug of mine from the monorepo transition that is preventing @magento/peregrine from being properly symlinked into venia-concept currently.
zetlen
suggested changes
Jun 19, 2018
| '^src/(.+)': '<rootDir>/src/$1', | ||
| // Re-write imports to Peregrine to ensure they're not pulled from the | ||
| // (possibly outdated) build artifacts on disk in `dist`. | ||
| // Ideally this rule would be in the root Jest config, but Jest's config |
There was a problem hiding this comment.
One tiny thing: Please put something like TODO: review when Jest revs here so that these tech debt items from dependencies are searchable.
jimbo
approved these changes
Jun 19, 2018
zetlen
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54.
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[X] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
See #54 .
Additional information