-
Notifications
You must be signed in to change notification settings - Fork 100
Add select all and tab controls #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ec46aef
add selext all and tab controls
fleytman d46c253
add tests
fleytman 65cca7f
add select and unselect info to README.rst
fleytman c1598fd
change link to mr
fleytman 163874e
fix tests
fleytman 30b95b6
remove shift+tab key
fleytman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,13 +66,13 @@ def get_options(self): | |
|
||
def process_input(self, pressed): | ||
question = self.question | ||
if pressed == key.UP: | ||
if pressed in (key.UP, key.SHIFT_TAB): | ||
if question.carousel and self.current == 0: | ||
self.current = len(question.choices) - 1 | ||
else: | ||
self.current = max(0, self.current - 1) | ||
return | ||
elif pressed == key.DOWN: | ||
elif pressed in (key.DOWN, key.CTRL_I): | ||
if question.carousel and self.current == len(question.choices) - 1: | ||
self.current = 0 | ||
else: | ||
|
@@ -89,6 +89,11 @@ def process_input(self, pressed): | |
elif pressed == key.RIGHT: | ||
if self.current not in self.selection: | ||
self.selection.append(self.current) | ||
elif pressed == key.CTRL_A: | ||
for x in self.question.choices: | ||
self.selection = list(range(len(self.question.choices))) | ||
elif pressed == key.CTRL_Q: | ||
self.selection = [] | ||
elif pressed == key.ENTER: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also I see there are no mentions of the changes on documentation and change-logs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where do i can found change-logs files? |
||
result = [] | ||
for x in self.selection: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added new branches to the code without adding tests for them. So this change request is reducing our test coverage. Please update the tests.