Support Django 1.9 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have tested this enough to be satisfied for now until we do the real fix.
| def validators(self): | ||
| # Hack around the fact that we inherit from DecimalField but don't hold | ||
| # Decimals. The real fix is to stop inheriting from DecimalField. | ||
| return [] |
There was a problem hiding this comment.
will this mean that I could give money field abc and it will properly store?
There was a problem hiding this comment.
Actually, I confirmed that (on Postgres at least) the amount will be stored in a numeric column, so the database will not store messed up data. Not ideal, but an OK compromise for the time being
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.