Skip to content

Conversation

makspll
Copy link
Owner

@makspll makspll commented Aug 18, 2025

Summary

Fixes issue where luau extensions are not recognized as lua

Copy link

semanticdiff-com bot commented Aug 18, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/bevy_mod_scripting_core/src/lib.rs  0% smaller

Copy link
Contributor

🐰 Bencher Report

Branchfix/luau-extension-regression
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,868.40 ns
(-18.50%)Baseline: 4,746.76 ns
6,213.99 ns
(62.25%)
component/access Rhai📈 view plot
🚷 view threshold
5,375.50 ns
(-19.09%)Baseline: 6,644.03 ns
7,943.53 ns
(67.67%)
component/get Lua📈 view plot
🚷 view threshold
2,166.50 ns
(-22.70%)Baseline: 2,802.69 ns
3,513.56 ns
(61.66%)
component/get Rhai📈 view plot
🚷 view threshold
4,089.10 ns
(-16.33%)Baseline: 4,887.02 ns
5,921.75 ns
(69.05%)
conversions/Mut::from📈 view plot
🚷 view threshold
84.38 ns
(-32.12%)Baseline: 124.30 ns
228.95 ns
(36.85%)
conversions/Ref::from📈 view plot
🚷 view threshold
81.92 ns
(-33.00%)Baseline: 122.26 ns
226.52 ns
(36.16%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
266.93 ns
(-50.25%)Baseline: 536.54 ns
1,080.53 ns
(24.70%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,314.90 ns
(-16.80%)Baseline: 1,580.34 ns
2,144.55 ns
(61.31%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
24.87 ns
(-35.63%)Baseline: 38.63 ns
61.47 ns
(40.46%)
conversions/Val::from_into📈 view plot
🚷 view threshold
277.40 ns
(-17.36%)Baseline: 335.67 ns
444.73 ns
(62.37%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,661.60 ns
(-18.85%)Baseline: 2,047.69 ns
2,472.75 ns
(67.20%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,314.10 ns
(-24.95%)Baseline: 1,750.90 ns
2,214.27 ns
(59.35%)
function/call Lua📈 view plot
🚷 view threshold
222.40 ns
(-18.75%)Baseline: 273.71 ns
331.39 ns
(67.11%)
function/call Rhai📈 view plot
🚷 view threshold
437.52 ns
(-15.15%)Baseline: 515.63 ns
661.37 ns
(66.15%)
loading/empty Lua📈 view plot
🚷 view threshold
52,546.00 ns
(-45.16%)Baseline: 95,809.60 ns
136,875.87 ns
(38.39%)
loading/empty Rhai📈 view plot
🚷 view threshold
290,950.00 ns
(-76.29%)Baseline: 1,227,225.00 ns
2,111,662.42 ns
(13.78%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
6,658.20 ns
(-14.05%)Baseline: 7,746.51 ns
9,039.71 ns
(73.66%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
6,052.30 ns
(-17.45%)Baseline: 7,331.59 ns
8,476.58 ns
(71.40%)
query/10 entities Lua📈 view plot
🚷 view threshold
18,539.00 ns
(-22.75%)Baseline: 23,998.66 ns
30,099.56 ns
(61.59%)
query/10 entities Rhai📈 view plot
🚷 view threshold
18,155.00 ns
(-24.18%)Baseline: 23,946.27 ns
28,540.92 ns
(63.61%)
query/100 entities Lua📈 view plot
🚷 view threshold
38,356.00 ns
(-21.30%)Baseline: 48,735.95 ns
60,169.51 ns
(63.75%)
query/100 entities Rhai📈 view plot
🚷 view threshold
30,360.00 ns
(-20.84%)Baseline: 38,350.66 ns
47,024.76 ns
(64.56%)
query/1000 entities Lua📈 view plot
🚷 view threshold
238,260.00 ns
(-23.64%)Baseline: 312,020.91 ns
378,438.72 ns
(62.96%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
150,840.00 ns
(-29.03%)Baseline: 212,540.00 ns
291,078.75 ns
(51.82%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,529.00 ns
(-14.52%)Baseline: 6,467.96 ns
7,448.40 ns
(74.23%)
reflection/10 Rhai📈 view plot
🚷 view threshold
15,078.00 ns
(-7.49%)Baseline: 16,298.84 ns
17,854.88 ns
(84.45%)
reflection/100 Lua📈 view plot
🚷 view threshold
46,959.00 ns
(-11.88%)Baseline: 53,288.34 ns
59,636.22 ns
(78.74%)
reflection/100 Rhai📈 view plot
🚷 view threshold
684,760.00 ns
(-8.16%)Baseline: 745,621.14 ns
875,399.26 ns
(78.22%)
resource/access Lua📈 view plot
🚷 view threshold
3,129.40 ns
(-25.22%)Baseline: 4,184.95 ns
5,423.47 ns
(57.70%)
resource/access Rhai📈 view plot
🚷 view threshold
4,883.90 ns
(-17.50%)Baseline: 5,920.18 ns
7,309.60 ns
(66.81%)
resource/get Lua📈 view plot
🚷 view threshold
1,754.70 ns
(-24.78%)Baseline: 2,332.73 ns
2,962.74 ns
(59.23%)
resource/get Rhai📈 view plot
🚷 view threshold
3,628.60 ns
(-14.18%)Baseline: 4,228.06 ns
5,229.52 ns
(69.39%)
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit 6eb6880 into main Aug 18, 2025
20 checks passed
@makspll makspll deleted the fix/luau-extension-regression branch August 18, 2025 20:10
@github-actions github-actions bot mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant