Skip to content

Conversation

holzman
Copy link
Contributor

@holzman holzman commented Jun 20, 2025

Description

Addresses #3830.

Nearly all of places where environment variables were set in the tests were needed, so I didn't change very much.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.57%. Comparing base (7cdf568) to head (d6d74d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3988   +/-   ##
=======================================
  Coverage   63.57%   63.57%           
=======================================
  Files         300      300           
  Lines       38401    38401           
  Branches     2861     2861           
=======================================
  Hits        24412    24412           
  Misses      13922    13922           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@holzman
Copy link
Contributor Author

holzman commented Jun 21, 2025

Weird, I must have broken something that worked for me locally. I'll take a look next week.

@holzman
Copy link
Contributor Author

holzman commented Jun 24, 2025

Oh, not my fault!

test_update.py::TestUpdateConfig::test_target_prefix_with_no_settings should have always been failing. It was only succeeding because MAMBA_ROOT_PREFIX was altered by earlier tests as a side effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants