Nullable in cosntructors, set NULLABLE flag when an element is null or if the array was created nullable

[Alex-PLACET]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 88.61538% with 37 lines in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (6576865) to head (fdc164b).

Files with missing lines	Patch %	Lines
src/arrow_array_schema_proxy.cpp	83.20%	21 Missing ⚠️
include/sparrow/layout/list_layout/list_array.hpp	60.00%	12 Missing ⚠️
...d_width_binary_layout/fixed_width_binary_array.hpp	87.50%	2 Missing ⚠️
...sparrow/layout/variable_size_binary_view_array.hpp	93.54%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   89.78%   89.74%   -0.04%     
==========================================
  Files          93       93              
  Lines        6941     7121     +180     
==========================================
+ Hits         6232     6391     +159     
- Misses        709      730      +21     

Flag	Coverage Δ
unittests	89.74% <88.61%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.

Files not reviewed (1)

• CMakeLists.txt: Language not supported

Comments suppressed due to low confidence (4)

include/sparrow/buffer/dynamic_bitset/dynamic_bitset_base.hpp:198

• Resizing the dynamic_bitset in operator[] when data() is nullptr may lead to unexpected side effects. Consider documenting this behavior or handling a null data pointer in a more explicit manner.

if (data() == nullptr) { resize(m_size, true); }

include/sparrow/arrow_interface/arrow_schema.hpp:111

• Aggregating flag values using bitwise OR assumes that multiple flags can be combined in this manner. Verify that this approach correctly represents the combined state for all intended flags.

for (const auto& flag : *flags) { schema.flags |= static_cast<int64_t>(flag); }

include/sparrow/layout/list_layout/list_array.hpp:592

• The use of a static flag set in one branch and std::nullopt in the other may lead to inconsistent flag representation across list array proxies. Ensure the flag usage is consistent between the nullable and non-nullable branches.

static const std::optional<std::unordered_set<ArrowFlag>> flags{{ArrowFlag::NULLABLE}};

include/sparrow/buffer/dynamic_bitset/dynamic_bitset_base.hpp:223

• The check for m_buffer being nullptr in the test() function contrasts with the behavior in operator[]. Ensure that the handling of null storage pointers is consistent and well-documented across all functions.

if (m_buffer == nullptr) { return true; }

[JohanMabille]

Why this change? The previous version was easier to read.

[Alex-PLACET]

ok, fixed

[JohanMabille]

What is the issue with directly using bool instead of NULLABLE_TYPE here? Same question for the other create_proxy mathods below since it looks to be a pattern.

[Alex-PLACET]

ok, fixed