Fix serverside zombie headcrab ragdoll not using correct origin #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h serverside ragdolls
Blixibon
deleted the
mapbase/feature/zombie-serverside-headcrab-ragdoll-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems with headcrab zombies not releasing their headcrabs properly when using serverside ragdolls. Previously, it used the direct origin of the newly created headcrab ragdoll gib, which isn't valid with serverside ragdolls. It would instead test a random position near the world origin which may or may not be clear. It would also show blood impacts at this location instead of near the zombie.
This adds a new parameter to the
CNPC_BaseZombie::HeadcrabFits()function to accept a separate origin, and while this function is virtual, it does not appear to be overridden by any zombie class in HL2.PR Checklist
developbranch OR targets another branch with a specific goal in mind