Hlmv port(2006) #401
Open
Hlmv port(2006) #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is extracted from https://github.com/Source-SDK-Resources/source-sdk-hlmv. I have done a minor cleanup of the code with some error/warning fixes. This does not contain any leak code (confirmed by the developer [ozxybox https://github.com/ozxybox]
I will left his PR as a draft since the compile on VS2013, VS2015, VS2019 is not tested (it should compile fine above VS2015 versions)
Also there are some issues with the hlmv port: such as Wireframe render mode doesnt work always, Normals and Tangent mode sometimes have the same issues.
Besides that this hlmv port is fine and robust.
PR Checklist
developbranch OR targets another branch with a specific goal in mind