Skip to content

vscript debugger cleanup #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

samisalreadytaken
Copy link

@samisalreadytaken samisalreadytaken commented Mar 3, 2025

Adds script_connect_debugger_on_mapspawn cvar from TF2. This is a much better method of attaching the debugger as soon as possible. They have script_attach_debugger_at_startup as well, but that doesn't seem useful.

Setting script_connect_debugger_on_mapspawn to 2 enables blocking ConnectDebugger call to wait for a client to connect. The timeout length is 10 seconds by defeault. I believe TF2 blocks forever (CSGO did and TF2 uses the same debugger).

Removes the debugger shutdown on failure to open network socket. The debugger can still be used for the profiler and disassembler without a client.

Adds the missing sqdbg licence file.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

@samisalreadytaken samisalreadytaken marked this pull request as draft March 23, 2025 12:02
@samisalreadytaken samisalreadytaken marked this pull request as ready for review April 1, 2025 13:28
@samisalreadytaken samisalreadytaken force-pushed the vscript-debugger branch 5 times, most recently from cb1ec59 to 8128fa9 Compare April 15, 2025 13:23
@samisalreadytaken samisalreadytaken force-pushed the vscript-debugger branch 4 times, most recently from e14f52a to 6a84787 Compare April 17, 2025 13:31
@samisalreadytaken samisalreadytaken marked this pull request as draft April 21, 2025 15:40
@samisalreadytaken samisalreadytaken marked this pull request as ready for review May 26, 2025 17:07
@Blixibon Blixibon merged commit 77a9ec6 into mapbase-source:develop May 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants