Skip to content

Fix typo in CBaseCombatWeapon::WeaponClassFromString #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

meatspace
Copy link

credit goes to Petercov for finding this not me

(i have no idea what this fixes/breaks)

Does this PR close any issues?

not that I know of

PR Checklist

  • [*] My PR follows all guidelines in the CONTRIBUTING.md file
  • [*] My PR targets a develop branch OR targets another branch with a specific goal in mind

credit goes to Petercov for finding this not me
Copy link
Member

@Blixibon Blixibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code several years ago to try to group weapons together in Mapbase's dynamic interaction expansions. This typo wouldn't have presented there, but I don't think there would be anything negatively affected by fixing this.

@Blixibon Blixibon merged commit bd43d3d into mapbase-source:develop May 30, 2025
4 checks passed
@meatspace meatspace deleted the patch-1 branch June 17, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants