Fallback if IScriptInstanceHelper::Get/Set are not implemented #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maintains parity with Valve's implementation.
When a variable is not found in a class, its get/set metamethods are called instead of falling back to the root environment. Since mapbase adds both to all classes regardless of whether they are implemented or not, expected fallbacks would fail.
An additional work to do would be adding a flag on
ScriptClassDesc_t
to indicate that a class hasIScriptInstanceHelper::Get/Set
implemented so that only those will have the metamethods created, saving about 10KB of memory (in 32 bit) as well.PR Checklist
develop
branch OR targets another branch with a specific goal in mind