Closed
Description
Diving into #4 led me to checking our usage of Nan::MakeCallback
, which led me to a few more tickets out in the wild about how it might not be the best thing in the world. Can we improve on our current usage?
refs:
- MakeCallback is dangerous, not only or best way of calling callback; provide direct method nodejs/nan#284
- change to node-osmium callbacks that we can learn from: osmcode/node-osmium@572fd27
- mapbox/mapbox-gl-native@706f0f2
- Refactors Bindinds to use Async Workers Project-OSRM/node-osrm#193 (comment)
node::MakeCallback()
API change for v6 nodejs/nan#548
Metadata
Metadata
Assignees
Labels
No labels