Skip to content

PHP-8 support #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2020
Merged

PHP-8 support #148

merged 4 commits into from
Oct 12, 2020

Conversation

marc-mabe
Copy link
Owner

@marc-mabe marc-mabe commented Sep 29, 2020 •
edited
Loading

  • PHP-8 compatibility
  • Restrict required PHP version to be ^7.1 or ^8.0 (before only the min version was defined)
  • Removed assertion polyfill code in tests and bench bootstrap for php < 7.0
    • this also fixes a segmentation fault running tests on PHP 8.0-rc

@marc-mabe marc-mabe added this to the 4.3.1 milestone Sep 29, 2020
@marc-mabe marc-mabe force-pushed the php8 branch 29 times, most recently from ce99c44 to 17f6cdf Compare October 10, 2020 19:39
@marc-mabe marc-mabe force-pushed the php8 branch 16 times, most recently from 7a3b2bc to f8c521f Compare October 11, 2020 21:04
@marc-mabe marc-mabe marked this pull request as ready for review October 11, 2020 21:22
@marc-mabe marc-mabe force-pushed the php8 branch 2 times, most recently from 008f463 to aa30bcc Compare October 12, 2020 20:23
Repository owner deleted a comment from codecov-io Oct 12, 2020
@marc-mabe marc-mabe merged commit a8e2071 into master Oct 12, 2020
@marc-mabe marc-mabe deleted the php8 branch October 12, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@marc-mabe