Skip to content

Prop for not setting inline width height #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Prop for not setting inline width height #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91a7dee
Add a prop to allow the inline width/height to not be set on the stic…
Mar 23, 2021
a04d4ed
bump version
Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "react-virtualized-sticky-tree",
"description": "A React component for efficiently rendering tree like structures with support for position: sticky",
"version": "3.0.0-beta12",
"version": "3.0.0-beta13",
"author": "Marc McIntyre <[email protected]>",
"license": "MIT",
"main": "lib/src/index.js",
Expand Down
17 changes: 12 additions & 5 deletions src/StickyTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ export interface StickyTreeProps<TNodeType extends TreeNode = TreeNode, TMeta =
*/
width: number;

/**
* if false, then the width and height are not set as inline styles on the sticky tree element.
*/
inlineWidthHeight?: boolean;

/**
* if true, the root node will be rendered (by calling rowRenderer() for the root id). Otherwise no root node will be rendered.
*/
Expand Down Expand Up @@ -930,11 +935,13 @@ export default class StickyTree<TNodeType extends TreeNode = TreeNode, TMeta = a

render() {
let style: React.CSSProperties = { overflow: 'auto', position: 'relative' };
if (this.props.width) {
style.width = this.props.width;
}
if (this.props.height) {
style.height = this.props.height;
if (this.props.inlineWidthHeight !== false) {
if (this.props.width) {
style.width = this.props.width;
}
if (this.props.height) {
style.height = this.props.height;
}
}

return (
Expand Down