Fix/log blocked chan

[frinfo702]

This pull request introduces error handling improvements for blocked notification channels and includes a minor cleanup in the server/server.go file. The most significant changes enhance logging and error reporting when notification channels are blocked.

Error handling improvements:

• func (s *MCPServer) SendNotificationToAllClients: Added logic to log an error using s.hooks.onError when a notification channel is blocked, including the session ID and method name in the error message.
• func (s *MCPServer) SendNotificationToClient: Enhanced error reporting by logging blocked notification channels with s.hooks.onError, providing session ID and method details, and returning a descriptive error message.

Code cleanup:

• func (s *MCPServer) AddResourceTemplate: Removed an unnecessary blank line for minor code cleanup.

Summary by CodeRabbit

• New Features
  • Added session management for client connections.
  • Enabled sending notifications to individual clients or all connected clients.
• Bug Fixes
  • Improved error reporting when notification channels are blocked during notification delivery.
• Style
  • Fixed missing newline at end of a test file for consistency.

[coderabbitai]

Walkthrough

The update moves session management and notification sending methods from server/session.go to server/server.go. It adds methods to associate sessions with contexts, register and unregister client sessions, and send JSON-RPC notifications to individual or all clients. Error hooks handle blocked notification channels and session lifecycle events. A trivial whitespace fix was applied to server/session_test.go.

Changes

Files	Change Summary
server/server.go	Added session management methods (WithContext, RegisterSession, UnregisterSession) and notification sending methods (SendNotificationToAllClients, SendNotificationToClient) with error reporting hooks for blocked notification channels and session lifecycle events.
server/session.go	Removed session management and notification sending methods (WithContext, RegisterSession, UnregisterSession, SendNotificationToAllClients, SendNotificationToClient).
server/session_test.go	Added a missing newline at the end of the file; no changes to logic or tests.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7a398a9 and a951d50.

📒 Files selected for processing (2)

• server/session.go (0 hunks)
• server/session_test.go (1 hunks)

💤 Files with no reviewable changes (1)

• server/session.go

✅ Files skipped from review due to trivial changes (1)

• server/session_test.go

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dugenkui03]

maybe you could wrap the error as requestError with INTERNAL_ERROR = -32603 , then the OnErrorHookFunc will know the error type.

[frinfo702]

Thank you for the explanation. I’ve applied it to my code.

[rwjblue-glean]

Seems good, thanks for working on it!

Would you mind rebasing? It would be great to also have a test case for this, but that might be kinda tricky so just let me know...

[rwjblue-glean]

@frinfo702 - Mind fixing up the conflicts?

[frinfo702]

Hi @robert-jackson-glean,

I’ve rebased fix/log-blocked-chan onto the latest main, resolved all conflicts, and force-with-lease-pushed the updated branch.
I haven’t added a test yet—happy to tackle that next if you’d like.

Could you please take another look when you have a moment?

Thanks for your time!

[frinfo702]

I noticed that the same functionality has already been merged in a different PR, including tests and proper integration.
Although this was based on my earlier implementation, I believe it’s best for the project to close this PR to avoid unnecessary duplication and confusion.

Thanks for reviewing — happy to contribute further in other areas.