Skip to content

feat(tools): 添加 GetAnySlice 和 RequireAnySlice 方法 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(tools): 添加 GetAnySlice 和 RequireAnySlice 方法 #433

wants to merge 2 commits into from

Conversation

Luoxin
Copy link

@Luoxin Luoxin commented Jun 22, 2025 •
edited by coderabbitai bot
Loading

  • GetAnySlice 方法用于获取 []any 类型的参数，如果不存在则返回默认值
  • RequireAnySlice 方法用于获取 []any 类型的参数，如果不存在或类型不匹配则返回错误

Summary by CodeRabbit

  • New Features
    • Added support for retrieving generic slices from tool request arguments, with options for default values or error handling when keys are missing.
  • Tests
    • Expanded test coverage to verify the new generic slice retrieval methods and their behavior with various value types and missing keys.

nico added 2 commits June 22, 2025 14:22
feat(tools): 添加 GetAnySlice 和 RequireAnySlice 方法
347b6d9 
- GetAnySlice 方法用于获取 []any 类型的参数，如果不存在则返回默认值
- RequireAnySlice 方法用于获取 []any 类型的参数，如果不存在或类型不匹配则返回错误
- 这两个方法扩展了 CallToolRequest 的功能，使其能够更方便地处理 any 类型的切片参数
test(mcp): 添加 GetAnySlice 和 RequireAnySlice 方法的单元测试
27c4c3f 
- 在 tools_test.go 文件中添加了 GetAnySlice 和 RequireAnySlice 方法的测试用例
- 测试了不同数据类型切片的获取，包括字符串、整数、浮点数和布尔值- 验证了方法在存在和不存在的键上的行为
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 22, 2025 •
edited
Loading

Walkthrough

Two new methods, GetAnySlice and RequireAnySlice, were added to the CallToolRequest type for retrieving arguments as []any slices. Corresponding tests were added to verify their behavior, including handling of various types and error conditions.

Changes

Files Change Summary
mcp/tools.go Added GetAnySlice and RequireAnySlice methods to CallToolRequest for handling []any slices.
mcp/tools_test.go Extended tests to cover GetAnySlice and RequireAnySlice methods, including type and error cases.

Possibly related PRs

Suggested labels

type: enhancement, area: sdk

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f5b048 and 27c4c3f.

📒 Files selected for processing (2)
  • mcp/tools.go (1 hunks)
  • mcp/tools_test.go (1 hunks)
🔇 Additional comments (3)
mcp/tools.go (2)

236-246: LGTM! Clean implementation following established patterns.

The method correctly implements the Get* pattern and appropriately handles only direct []any type assertions without conversion attempts, which maintains type clarity.

248-260: LGTM! Consistent error handling and pattern adherence.

The method properly implements the Require* pattern with appropriate error messages that match the established format used by other similar methods.

mcp/tools_test.go (1)

397-409: LGTM! Comprehensive test coverage for the new methods.

The tests properly validate both success and error cases for GetAnySlice and RequireAnySlice, covering various slice types (string, int, float, bool) and missing key scenarios. The test structure follows established patterns in the codebase.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Luoxin