Skip to content

Conversation

win-cmd
Copy link

@win-cmd win-cmd commented Aug 27, 2025

Description

Fixes #<issue_number> (if applicable)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • MCP spec compatibility implementation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Tests only (no functional changes)
  • Other (please describe):

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation accordingly

MCP Spec Compliance

  • This PR implements a feature defined in the MCP specification
  • Link to relevant spec section: Link text
  • Implementation follows the specification exactly

Additional Information

Summary by CodeRabbit

  • New Features

    • Improved reliability of HTTP sampling requests with better request/response routing and overload handling.
    • Tool call results now always include the isError field in JSON responses for consistency.
  • Documentation

    • Rebranded import paths, links, and badges to the new repository; updated installation and examples across docs.
    • Added a Tutorial YouTube badge/link to the README.
  • Tests

    • Updated test imports and expanded sampling scenarios for HTTP transport.
  • Chores

    • Updated module path, discussion/issue links, and contact emails across configuration and policy files.

Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Repository rebranded from mark3labs to rickey17: module path updated in go.mod, source, tests, examples, and docs. Contact links/emails adjusted. Functional changes include always emitting isError in mcp/tools.go JSON and revised sampling flow/channel routing in server/streamable_http.go. Examples and tests updated accordingly.

Changes

Cohort / File(s) Summary
Module rename & import updates (source)
go.mod, client/... (non-test), client/transport/... (non-test), server/... (non-test), mcptest/*.go, examples/*/*.go, testdata/mockstdio_server.go
Change module to github.com/rickey17/mcp-go; replace imports from github.com/mark3labs/mcp-go/... to github.com/rickey17/mcp-go/.... No logic changes except where noted separately.
Module rename & import updates (tests)
client/*_test.go, client/transport/*_test.go, server/*_test.go, mcptest/mcptest_test.go
Update test imports to new module path; preserve test logic and behavior.
Docs & metadata rebrand
.github/ISSUE_TEMPLATE/config.yml, README.md, CODE_OF_CONDUCT.md, CONTRIBUTING.md, SECURITY.md, www/docs/pages/..., www/vocs.config.ts
Update links, emails, badges, install/import snippets to rickey17/mcp-go. Add Tutorial YouTube badge in README. No code logic.
JSON marshalling tweak
mcp/tools.go
CallToolResult.MarshalJSON now always includes the boolean isError field (true/false) in output.
Streamable HTTP server sampling flow
server/streamable_http.go
Add per-request channel mapping (samplingRequests[requestID] = responseChan), non-blocking dispatch with select handling cancellation/queue-full, and wait/route response via responseChan. Formatting/whitespace tweaks elsewhere.
SSE transport formatting
client/transport/sse.go
Import path updates plus minor whitespace/alignment; no functional changes.
Sampling HTTP example enhancement
examples/sampling_http_client/main.go
Switch to new imports; add MockSamplingHandler, use Client.Start(ctx), set ClientInfo, graceful shutdown, and structured sampling response construction.
Sampling HTTP client tests update
client/transport/streamable_http_sampling_test.go
Update imports; expand tests to include structured messages, error handling (-32603), method-not-found (-32601), concurrency order, and result content assertions.
Minor sample/test adjustments
client/transport/streamable_http.go, client/transport/streamable_http_*_test.go, server/streamable_http_*_test.go
Import updates and whitespace-only edits; no functional changes beyond the dedicated sampling test file.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • robert-jackson-glean
  • rwjblue-glean
  • pottekkat

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e353ac and 63315ed.

⛔ Files ignored due to path filters (2)
  • server/internal/gen/hooks.go.tmpl is excluded by !**/gen/**
  • server/internal/gen/request_handler.go.tmpl is excluded by !**/gen/**
📒 Files selected for processing (88)
  • .github/ISSUE_TEMPLATE/config.yml (1 hunks)
  • CODE_OF_CONDUCT.md (1 hunks)
  • CONTRIBUTING.md (1 hunks)
  • README.md (4 hunks)
  • SECURITY.md (1 hunks)
  • client/client.go (1 hunks)
  • client/http.go (1 hunks)
  • client/http_test.go (1 hunks)
  • client/inprocess.go (1 hunks)
  • client/inprocess_sampling_test.go (1 hunks)
  • client/inprocess_test.go (1 hunks)
  • client/interface.go (1 hunks)
  • client/oauth.go (1 hunks)
  • client/oauth_test.go (1 hunks)
  • client/protocol_negotiation_test.go (1 hunks)
  • client/sampling.go (1 hunks)
  • client/sampling_test.go (1 hunks)
  • client/sse.go (1 hunks)
  • client/sse_test.go (1 hunks)
  • client/stdio.go (1 hunks)
  • client/stdio_test.go (1 hunks)
  • client/transport/inprocess.go (1 hunks)
  • client/transport/interface.go (1 hunks)
  • client/transport/sse.go (3 hunks)
  • client/transport/sse_test.go (1 hunks)
  • client/transport/stdio.go (1 hunks)
  • client/transport/stdio_test.go (1 hunks)
  • client/transport/streamable_http.go (5 hunks)
  • client/transport/streamable_http_oauth_test.go (1 hunks)
  • client/transport/streamable_http_sampling_test.go (15 hunks)
  • client/transport/streamable_http_test.go (1 hunks)
  • examples/custom_context/main.go (1 hunks)
  • examples/dynamic_path/main.go (1 hunks)
  • examples/everything/main.go (1 hunks)
  • examples/filesystem_stdio_client/main.go (1 hunks)
  • examples/in_process/main.go (1 hunks)
  • examples/inprocess_sampling/main.go (1 hunks)
  • examples/oauth_client/main.go (1 hunks)
  • examples/sampling_client/main.go (2 hunks)
  • examples/sampling_http_client/main.go (6 hunks)
  • examples/sampling_http_server/main.go (2 hunks)
  • examples/sampling_server/main.go (1 hunks)
  • examples/simple_client/main.go (1 hunks)
  • examples/structured_input_and_output/main.go (1 hunks)
  • examples/typed_tools/main.go (1 hunks)
  • go.mod (1 hunks)
  • mcp/tools.go (1 hunks)
  • mcptest/mcptest.go (1 hunks)
  • mcptest/mcptest_test.go (1 hunks)
  • server/hooks.go (1 hunks)
  • server/inprocess_session.go (1 hunks)
  • server/request_handler.go (1 hunks)
  • server/resource_test.go (1 hunks)
  • server/sampling.go (1 hunks)
  • server/sampling_test.go (3 hunks)
  • server/server.go (1 hunks)
  • server/server_race_test.go (1 hunks)
  • server/server_test.go (1 hunks)
  • server/session.go (1 hunks)
  • server/session_test.go (1 hunks)
  • server/sse.go (1 hunks)
  • server/sse_test.go (1 hunks)
  • server/stdio.go (1 hunks)
  • server/stdio_test.go (1 hunks)
  • server/streamable_http.go (6 hunks)
  • server/streamable_http_sampling_test.go (2 hunks)
  • server/streamable_http_test.go (1 hunks)
  • testdata/mockstdio_server.go (1 hunks)
  • www/docs/pages/clients/advanced-sampling.mdx (3 hunks)
  • www/docs/pages/clients/basics.mdx (1 hunks)
  • www/docs/pages/clients/index.mdx (2 hunks)
  • www/docs/pages/clients/operations.mdx (2 hunks)
  • www/docs/pages/clients/transports.mdx (1 hunks)
  • www/docs/pages/getting-started.mdx (3 hunks)
  • www/docs/pages/index.mdx (1 hunks)
  • www/docs/pages/quick-start.mdx (4 hunks)
  • www/docs/pages/servers/advanced-sampling.mdx (3 hunks)
  • www/docs/pages/servers/advanced.mdx (2 hunks)
  • www/docs/pages/servers/basics.mdx (1 hunks)
  • www/docs/pages/servers/index.mdx (1 hunks)
  • www/docs/pages/servers/prompts.mdx (1 hunks)
  • www/docs/pages/servers/resources.mdx (1 hunks)
  • www/docs/pages/transports/http.mdx (1 hunks)
  • www/docs/pages/transports/index.mdx (1 hunks)
  • www/docs/pages/transports/inprocess.mdx (2 hunks)
  • www/docs/pages/transports/sse.mdx (1 hunks)
  • www/docs/pages/transports/stdio.mdx (3 hunks)
  • www/vocs.config.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@win-cmd win-cmd closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant