Skip to content

Added failing test for reading a DocumentPage #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jul 30, 2024

The test is disabled as I'm using it to do some refactoring first and then figure out how to use OkHttp's newish MultipartReader to fix this problem.

Other changes:

  1. Did some refactoring in OkHttpServices to make the code for reading a multipart response easier to read and eventually change to use OkHttp's MultipartReader.
  2. Formatted Common and AbstractOpticUpdateTest.

The test is disabled as I'm using it to do some refactoring first and then figure out how to use OkHttp's newish MultipartReader to fix this problem. 

Other changes:

1. Did some refactoring in `OkHttpServices` to make the code for reading a multipart response easier to read and eventually change to use OkHttp's MultipartReader.
2. Formatted Common and AbstractOpticUpdateTest.
@rjrudin rjrudin merged commit ee87ee5 into develop Jul 30, 2024
1 check passed
@rjrudin rjrudin deleted the feature/multipart-response-refactor branch July 31, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants