-
Notifications
You must be signed in to change notification settings - Fork 50
Outdated dependencies #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There are also a bunch of deprecation warnings on
These may or may not be the result of secondary dependencies. |
Investigating. I'm seeing the following as of 9e788d2:
Also:
|
I updated the package.json with everything in the above "npm outdated" list (incuding the concat-stream to ^1.6.0, which wasn't showing up in my list). I ran the tests in test-basic and had to correct one thing, a file reference in bluebird-plus.js. Once I did that, the tests in test-basic all passed:
Next I will attempt to fix items on the deprecated list. I also need to:
So far, things look very promising (no pun intended). |
What’s our philosophy on shrinkwrap? |
I researched shrinkwrap and presented to the API Team: https://wiki.marklogic.com/display/~mwooldri/npm+shrinkwrap The response from the team was positive. We've also implemented this in Samplestack. Once our dependencies are locked down for this Node Client API release and the code is tested by QA, I'd like to add a shrinkwrap file to lock down dependencies. @jmakeig, if you're on board with this I will add a task. @ayuwono, let me know if QA has concerns. |
Tested certificate authentication with updated dependencies by running through the steps in the README here: https://github.com/wooldridge/ml-certauth Test passed. |
In testing with Kerberos, I'm running into the following error:
It seems my client and the KDC are out of sync with regard to their clocks. Some info here: Investigating with Arthur. |
There was a hiccup running the examples (running the query-builder.js example), but this doesn't appear to be related to the updated dependencies. Earlier branches with the older dependencies are showing the same issue. Filed an issue here: #362 |
Arthur fixed the problem described in #343 (comment). He said:
After the fix, the manual Kerberos tests passed. |
Clock Skew Too Great also happens to be the name of my experimental prog rock collective. |
CSTG played a mighty progressive show to four discerning gray-ponytailed fans at the Konocti resort in Lake County. |
I'm going to move the module updates in package.json here to test for QA since they've passed all my preliminary tests (test-basic, cert auth, Kerberos, examples). I'm going to move the deprecation warnings to a separate issue. Based on my investigation so far, we need to update our documentation library, jsdoc (and gulp-jsdoc). The gulp-jsdoc library is no longer being maintained, see: https://www.npmjs.com/package/gulp-jsdoc We need to update to the following:
Doing this will get rid of half the Updating the jsdoc stuff will take a bit of effort since the gulp-jsdoc API has changed, which is why I'd like to move the deprecation fixes to a separate issue. Not sure what we can do about the remaining deprecation warnings since none of them are due to direct dependencies of the Node.js Client API. But I will investigate after I deal with the jsdoc update. |
Updated dependencies to current versions based on running "npm outdated". Updated file path for new version of bluebird. Fixed minor linting errors.
task(#343): update dependencies in package.json
@ayuwono, please test the API with the merged updates to package.json. |
Tested and verified |
As of b8c7828,
npm outdated
yields:A major release is probably the best time to upgrade any/all of these. However, we should only upgrade if there's a good reason. Some of these may have incompatibilities.
The text was updated successfully, but these errors were encountered: