fix(#250): add borrows JSDoc references to values-builder.js #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kcoleman-marklogic can you review this fix? |
For geospatial() and geospatialRegion()
wooldridge
changed the title
Method comes via query-builder.js
|
I would be glad to, if I had any idea what the result is supposed to be. The issue (#250) describes the solution, not the problem. |
|
This looks OK to me, modulo what I said about region lexicon queries in #250. I think you need to take out the |
Values query over region index is not currently supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For geospatial() and geospatialRegion().
Fixes #250