Adds new required libraries #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future, we might want to reduce the multiple COPY commands to a single COPY to reduce the number of container image layers created. |
|
Can you explain why these libraries are required? I see them added in the docker images, but not in the stand-alone build script. Is there a reason why there is not parity? |
|
They appear to be a newer requirement for cuda supported builds. This is the reason the test validation is not completing for cuda related images. I'm assuming this requirement was introduced in the bump from ffmpeg v4.4 to the v5.0 release. |
|
Thx. Will check 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.