Skip to content

build-ffmpeg: ffmpeg source and cmake minor version update #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2021

Conversation

rokibhasansagar
Copy link
Contributor

  • The previous script was breaking in the middle of compilation without this patch. Now the script will download cmake source from proper path.
  • Version number fetching could be made autonomous if jq could be used in all build platforms (IDK if they are prebuilt in the systems) as cmake keeps note of the latest version in a JSON file in the Release Directory.

@rokibhasansagar

This comment has been minimized.

- Tagged snapshot from ffmpeg.org is not updated once published. But the release head branches in git source is occasionally updated with most-stable changes from master branch.
@rokibhasansagar rokibhasansagar changed the title build-ffmpeg: cmake minor version update build-ffmpeg: ffmpeg source and cmake minor version update Jul 24, 2021
@mxsrm
Copy link

mxsrm commented Jul 24, 2021

Using "https://github.com/Kitware/CMake/releases/download/v3.21.0/cmake-3.21.0.tar.gz" instead of the path from cmake.org will prevent this from breaking every time a new version is released.

@rokibhasansagar
Copy link
Contributor Author

Using "https://github.com/Kitware/CMake/releases/download/v3.21.0/cmake-3.21.0.tar.gz" instead of the path from cmake.org will prevent this from breaking every time a new version is released.

I updated the version number manually, and your suggestion does the exact thing.
There's no Automation in either of our methods 👎🏼

@mxsrm
Copy link

mxsrm commented Jul 24, 2021

Yes but when cmake updates to a new version the link at https://cmake.org/files/LatestRelease/ is deleted. This script fails. My method will continue to work because the github link stays valid and the build will continue to work with the (now old) version of cmake in the script.

@markus-perl markus-perl merged commit d6fee6a into markus-perl:master Jul 24, 2021
@rokibhasansagar rokibhasansagar deleted the patch-1 branch July 25, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants