Fix useMutationWithMutationMode
in optimistic
and undoable
mode may pass invalid parameters to the mutation
#10977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #10857, when passing parameters at declaration time to a mutation hook in
optimistic
orundoable
mode, those params may be modified by the side effects before the actual mutation is called.For instance, if you pass the
selectedIds
from theListContext
to auseUpdateMany
hook and use theuseUnselectAll
hook to reset theselectedIds
in theonSuccess
side effect, then the actual mutation will be called with an empty array of ids.You can see the issue like this:
updateMany
Solution
Keep the params in an additional ref that is freezed once the
mutate
callback is called.How To Test
make run
updateMany
Additional Checks
master
for a bugfix or a documentation fix, ornext
for a feature