Skip to content

Noting support for OpenAPI v3 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Conversation

earth2marsh
Copy link
Contributor

… and some cleanup to other OpenAPI references.

(note: because this is a docs change, I didn't bother opening an issue—hope that's ok!)

… and some cleanup to other OpenAPI references.
@lafrech
Copy link
Member

lafrech commented Apr 4, 2018

(No pb, you don't have to open an issue when you open a PR.)

OpenAPI v3 support is being worked on, but I'm not sure it should be advertised as "supported" already. @Bangertm, what do you think?

BTW, the work on this can be followed in #165.

@Bangertm
Copy link
Collaborator

Bangertm commented Apr 4, 2018

It's advertised as:

A pluggable API specification generator. Currently supports the OpenAPI (versions 2.0 and 3.0) spec.

On marshmallow-code. The 3.0 support is fairly rudimentary though. It's basically what you get after running a 2.0 spec through a 2 to 3 converter tool. No support for any of the new features of 3.0 (such as polymorphism 😉).

@sloria
Copy link
Member

sloria commented Apr 5, 2018

Maybe the docs should read "Currently supports OpenAPI Specification version 2, with limited support for version 3" ?

now better explains that it has limited support for OAS v3
@earth2marsh
Copy link
Contributor Author

Thanks for clarifying. I've taken a pass to encorporate the suggested changes, HTH!

When more complete v3 support lands, would love to add you to the OpenAPI Implementations list.

@sloria
Copy link
Member

sloria commented Apr 10, 2018

Thanks!

@sloria sloria merged commit 84b985a into marshmallow-code:dev Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants