Skip to content

[Fix #69] Support the flask APPLICATION_ROOT config #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2016

Conversation

deckar01
Copy link
Member

Prefix the formatted swagger path with the APPLICATION_ROOT from the flask app's configuration settings.

I mentioned in a comment on the issue that I preferred to lean on the url_adapter interface, but it does not expose a string transformation of the endpoint that does not require providing the values for the parameters.

Note: I opted for the try/except import to support python 2 & 3, because future is not currently a dependency of the project.
https://docs.python.org/3/howto/pyporting.html

@sloria
Copy link
Member

sloria commented Apr 29, 2016

Looks great! Thanks @deckar01

@sloria sloria merged commit 2923106 into marshmallow-code:dev Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants