Skip to content

Switch to minimal hosting and actions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Jul 30, 2021
Merged

Conversation

martincostello
Copy link
Owner

@martincostello martincostello commented Jun 27, 2021

Refactor the application to use the new minimal hosting and actions features of ASP.NET Core 6 using a daily build of Release Candidate 1.

Various workarounds have been applied for known issues, but the test still fails due to Razor pages not working. This seems to be because the content root applied by the tests does not take effect.

Move to using WebApplicationBuilder using a daily build of .NET 6 preview 6.
Update the endpoints to use new minimal APIs.
Bind the item Ids as a Guid instead of a string.
Add workaround to bootstrap the HttpServerFixture when using top-level programs.
Add workaround for test configuration changes not being used.
Add link to PR to support ClaimsPrincipal.
When the debugger is attached, wait indefinitely for the host to start.
Explicitly configure the development environment due to issue with it not being set by default.
Simplify the bootstrapping to leverage implicit conventions.
Set the minimum logging level for the tests to debug while there's still issues with things.
Use JsonResult instead of ObjectResult.
Pre-empt changes coming in a future preview, as it reduces the amount of code in the endpoints and gets rid of the need to cast to IResult for resolving ambiguity.
Update to a daily build of .NET 6 preview 7.
Remove workaround for timeout when debugging host startup which is now fixed.
As of preview 7, the SDK now uses C# 10 by default.
Document the HTTP status codes that each API endpoint returns.
Update to latest .NET 6 daily build of the SDK.
React to additional built-in global using statements.
Move some workarounds to only be for Visual Studio, rather than also on the CLI.
Update to the latest daily build of the .NET 6 preview 7 SDK.
Use Problem(...) instead of BadRequest() and NotFound().
Remove the route attributes as they Just Work anyway.
Use new() instead of explicit type.
Update to a newer version of the .NET 6 preview 7 SDK.
Remove workaround for broken Swagger documentation.
Add workaround for "preview features" warning.
Move CA2252 workaround to the props file instead of the code.
Remove workarounds required to build in Visual Studio that are not required with Visual Studio 2022 17.0.0 Preview 2.0.
Switch to using file-scoped namespaces.
Update to an RC1 build of the .NET SDK.
Remove HACK to prevent spurious code analysis warning.
Update to a newer RC1 build that includes fix for missing endpoint metadata.
Refactor the extension methods to resemble those proposed to be added to ASP.NET Core in a future build.
Tweak the indentation etc. for the actions.
Update to a newer build of the .NET SDK.
Update to a newer .NET 6 SDK RC1 build.
Remove need to explicitly configure UseDeveloperExceptionPage().
Update .NET SDK to pick up fix for issues with IConfiguration and remove workaround.
Remove unused method from HttpServerFixture.
Update to the latest daily build of the .NET 6 RC1 SDK.
Add Microsoft.Net.Compilers.Toolset so that file-scoped namespaces compile in Visual Studio 2022 preview 2.
Update to the latest .NET 6 SDK for RC1.
Remove workarounds for fixed issues.
Fix warnings in test logs about use of HTTP.
Add a new line between the namespace and the class declaration.
@martincostello martincostello added .NET Pull requests that update .net code enhancement New feature or request labels Jul 30, 2021
@martincostello martincostello marked this pull request as ready for review July 30, 2021 07:26
@martincostello martincostello merged commit 36089c5 into main Jul 30, 2021
@martincostello martincostello deleted the minimal-hosting branch July 30, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant