Skip to content

Fix #issue 2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Fix #issue 2 #3

merged 2 commits into from
Aug 19, 2020

Conversation

neviaumi
Copy link
Contributor

@neviaumi neviaumi commented Aug 19, 2020

This PR is aim to fix #2

according to Inquire.js documentation, the choices must be present when using list

So i set the default value when type-enum abs.

Also, i has mark scope possible to leave it blank by added :skip to scope choices list.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #3 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   78.12%   78.30%   +0.18%     
==========================================
  Files          12       12              
  Lines         352      355       +3     
  Branches       78       81       +3     
==========================================
+ Hits          275      278       +3     
  Misses         76       76              
  Partials        1        1              
Flag Coverage Δ
#unittests 78.30% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prompts/scope-maker.ts 100.00% <100.00%> (ø)
src/prompts/type-maker.ts 100.00% <100.00%> (ø)

@neviaumi
Copy link
Contributor Author

CI fail due to Bad credentials on wagoid/commitlint-github-action@v1

image

Copy link
Owner

@martinmcwhorter martinmcwhorter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that

@martinmcwhorter martinmcwhorter merged commit 1ca953c into martinmcwhorter:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with lerna
2 participants