fix(scope-maker): exclude skip choice when required #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for commitlint 'scope-empty' rule choice builder
add tests for scope-empty rule with `disabled` and `warn` severity levels
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 78.30% 79.03% +0.72%
==========================================
Files 12 12
Lines 355 372 +17
Branches 81 85 +4
==========================================
+ Hits 278 294 +16
- Misses 76 77 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hi @martinmcwhorter! |
|
Probably best a conversation for the open issue #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
:skipchoice option is shown in the list of scope choice options, even when commitlintscope-emptyrule level is set to2(error) with applicability set tonever, which means it is not possible to leave the scope empty, and it causes an error.This pull request fixes the bug and disallows
:skipchoice option from being selected when thescope-emptyrule severity is set to2(error) and its applicability is set tonever.Also, some refactoring is done in order to improve readability and separation of concerns.