Address the still unfixed issues related to setStatusBarColor and setNavigationBarColor warning targeting API level 35 and above #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMH17
changed the title
SMH17
changed the title
SMH17
changed the title
…NavigationBarColor warning targeting API level 35 and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since API 35 setStatusBarColor() is deprecated and not working anymore, setNavigationBarColor() doesn't affect gesture navigation and nav bar is set to match window background.
If static code analysis in Google Play Store platform detects such calls done in the code of apps targeting API 35 and newer, it generates a warning (that could have also consequences on app quality metrics).
This update enwraps such calls in a conditional check that ensures that they aren't done in Android API 35 and above.
Related discussions #4626 , #4507 and #10304.