don't lock shrine_images' version #141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't lock the version of `shrine_images` otherwise we might end up with unresolvable dependencies: ``` Because Shrine depends on shrine_images <1.1.1 which requires SDK version >=1.19.0 <2.1.0, version solving failed. ```
|
So, checked with the rest of the team. Not locking to a version is considered an anti-pattern (even if it's a really good brute force here.) Let's keep the package and the pubspec as up-to-date as possible instead. When I check the pubspec, it looks like it's now at 1.1.1 which is a much higher SDK minimum. So I think we should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't lock the version of
shrine_imagesotherwise we might end up with unresolvable dependencies: