Skip to content

104 complete #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 51 commits into from
Closed

104 complete #39

wants to merge 51 commits into from

Conversation

saltpetre
Copy link

No description provided.

willlarche and others added 21 commits June 11, 2018 12:32
…#22)

* [104] Replaces regular hamburger menu behavior with a branded icon version.

* Fixed space nit and refactored branded icon into its own var.

* whitespace
* [104] Clarifying backdrop.

* [104] Changing panel to layer.
* [104] PR feedback.

* [104] PR feedback.

* [104] Some whitespace.
* [101] Correcting widget class.

* [101] Complete code.
[102] Starter code.

* [102] Minor copy correction.

* [101] Update for Dart 2

* [102] Complete code.
[103] Starter code.

* [102] Correcting home being stateful.

* [103] Correcting order of fields. (#10)

* [102] Removing unneeded value.

* [102] Dart 2.

* [102] Data correction.

* [103] Completed code.
[104] Starter code.

* [103] Removing unneeded directory.

* [103] Unused icons code.

* [103] Moving supplemental files.

* [103] Using recent changes.

* [103] Removing unused import.

* [103] Data correction.

* [103] Adding body2 styling.

* [103] Dart 2

* [103] Color const correction.

* [102] Complete code.
[103] Starter code.

* [103] Completed code.
[104] Starter code.

* [103] Completed code.
[104] Starter code.

* [103] Correcting order of fields. (#10)

* add backdrop and working menu with filtering

* [104] Minor visual changes.

* [103] Using recent changes.

* [104] Visual detail.

* [104] Newline at EOF.

* [104] License stanzas.

* [104] Removing files from merge.

* [104] Sync.

* [104] Correcting license

* [104] Adding license stanza

* [104] Decrease backdrop radius size to match mocks. (#21)

* [104] PR feedback.

* [104] Removing an unnecessary widget.

* [104] Formatting.

* [104] Replaces regular hamburger menu behavior with a branded version (#22)

* [104] Replaces regular hamburger menu behavior with a branded icon version.

* Fixed space nit and refactored branded icon into its own var.

* whitespace

* [104] Changing "Panel" to "Layer" (#24)

* [104] Clarifying backdrop.

* [104] Changing panel to layer.

* Start to reconfigure the _BackdropTitle to handle custom transition animations.

* Added a customIcon to _BackdropTitle with the correct animations for branded icon.

* Added front and back title sliding to the branded icon animation.

* [104] Merge sync. (#27)

* Start to reconfigure the _BackdropTitle to handle custom transition animations.

* Added a customIcon to _BackdropTitle with the correct animations for branded icon.

* Added front and back title sliding to the branded icon animation.

* rebase fixes

* Responded to comments

* merge fix

* Rearranged the animations and used nested widgets instead of transitions with no local vars.

* Fix bad rebase

* Respond to comments by replacing .animate with .evaluate
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@willlarche
Copy link
Collaborator

Hey, @saltpetreca , we don't want the code from 104 merged into 101. I'm gonna close this. Write back if you have any questions.

@willlarche willlarche closed this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants