Skip to content

[103] starter todos #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018
Merged

[103] starter todos #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mdc_100_series/lib/app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class ShrineApp extends StatelessWidget {
home: HomePage(),
initialRoute: '/login',
onGenerateRoute: _getRoute,
// TODO: Add a theme (103)
);
}

Expand All @@ -40,3 +41,6 @@ class ShrineApp extends StatelessWidget {
);
}
}

// TODO: Build a Shrine Theme (103)
// TODO: Build a Shrine Text Theme (103)
4 changes: 4 additions & 0 deletions mdc_100_series/lib/home.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ class HomePage extends StatelessWidget {

return products.map((product) {
return Card(
// TODO: Adjust card heights (103)
child: Column(
// TODO: Center items on the card (103)
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[
AspectRatio(
Expand All @@ -48,7 +50,9 @@ class HomePage extends StatelessWidget {
child: Padding(
padding: EdgeInsets.fromLTRB(16.0, 12.0, 16.0, 8.0),
child: Column(
// TODO: Align labels to the bottom and center (103)
crossAxisAlignment: CrossAxisAlignment.start,
// TODO: Change innermost Column
children: <Widget>[
// TODO(larche): Make headline6 when available
Text(
Expand Down
8 changes: 8 additions & 0 deletions mdc_100_series/lib/login.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ class _LoginPageState extends State<LoginPage> {
],
),
SizedBox(height: 120.0),
// TODO: Wrap Username with PrimaryColorOverride (103)
// TODO: Remove filled: true values (103)
TextField(
controller: _usernameController,
decoration: InputDecoration(
Expand All @@ -47,6 +49,7 @@ class _LoginPageState extends State<LoginPage> {
),
),
SizedBox(height: 12.0),
// TODO: Wrap Password with PrimaryColorOverride (103)
TextField(
controller: _passwordController,
decoration: InputDecoration(
Expand All @@ -57,13 +60,16 @@ class _LoginPageState extends State<LoginPage> {
),
ButtonBar(
children: <Widget>[
// TODO: Add a beveled rectangular border to CANCEL (103)
FlatButton(
child: Text('CANCEL'),
onPressed: () {
_usernameController.clear();
_passwordController.clear();
},
),
// TODO: Add an elevation to NEXT (103)
// TODO: Add a beveled rectangular border to NEXT (103)
RaisedButton(
child: Text('NEXT'),
onPressed: () {
Expand All @@ -78,3 +84,5 @@ class _LoginPageState extends State<LoginPage> {
);
}
}

// TODO: Add PrimaryColorOverride (103)